On 12/15/21 at 05:59am, cgel....@gmail.com wrote:
> From: Minghao Chi <chi.ming...@zte.com.cn>
>
> Return value from kimage_add_entry() directly instead
> of taking this in another redundant variable.
> Reported-by: Zeal Robot <zea...@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.ming...@zte.com.cn>
Nice clean up, looks good to me. Thx.
Acked-by: Baoquan He <b...@redhat.com>
>
> ---
> kernel/kexec_core.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index 5a5d192a89ac..574391de1f83 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -561,23 +561,17 @@ static int kimage_add_entry(struct kimage *image,
> kimage_entry_t entry)
> static int kimage_set_destination(struct kimage *image,
> unsigned long destination)
> {
> - int result;
> -
> destination &= PAGE_MASK;
> - result = kimage_add_entry(image, destination | IND_DESTINATION);
>
> - return result;
> + return kimage_add_entry(image, destination | IND_DESTINATION);
> }
>
>
> static int kimage_add_page(struct kimage *image, unsigned long page)
> {
> - int result;
> -
> page &= PAGE_MASK;
> - result = kimage_add_entry(image, page | IND_SOURCE);
>
> - return result;
> + return kimage_add_entry(image, page | IND_SOURCE);
> }
>
>
> --
> 2.25.1
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
