Stop using the WiX Registry element
It is deprecated in favor of more specific XML elements such as RegistryKey, RegistryValue, and RemoveRegistryKey, so as to stop overloading a single element for what are fundamentally different types and operations. RegistryValue elements can be children of RegistryKey elements, allowing the Key attribute to be inherited, or bare within the containing Component. We do not take advantage of the inheritance at this time, since that would be a more disruptive change. WiX would prefer for us to not use the createAndRemoveOnUninstall attribute of <RegistryKey>, in favor of ForceCreateOnInstall and/or ForceRemoveOnUninstall, but that can wait for a follow-up commit. Some instances of <Registry> were commented-out and can simply be removed. Some of the <Registry> elements used to create keys were also setting the KeyPath attribute, which is not permitted in the <RegistryKey> element. According to http://sourceforge.net/p/wix/bugs/3197/ , this should never have been allowed, and non-value registry keys should not be used as MSI KeyPaths. In all affected cases, there are child RegistryValue elements that are suitable for use as KeyPath elements instead. Some of the <Registry> elements were present with a duplicate element with different Id that added no new attributes; those duplicate elements can safely be removed. <RemoveRegistryKey> is used to replace <Registry> elements with Action=removeKeyOnInstall. https://github.com/krb5/krb5/commit/280a4b1125743bae3bf05af266131e2a524c8adf Author: Ben Kaduk <ka...@mit.edu> Commit: 280a4b1125743bae3bf05af266131e2a524c8adf Branch: master src/windows/installer/wix/files.wxi | 269 ++++++++++++++++------------------- 1 files changed, 126 insertions(+), 143 deletions(-) _______________________________________________ kfwdev mailing list kfwdev@mit.edu http://mailman.mit.edu/mailman/listinfo/kfwdev
