On Sun, Sep 03, 2006 at 09:37:26PM +0400, Sergei Shtylyov wrote: > Hello. > > Sergei Shtylyov wrote: > > >>> We've found out that drivers/serial/serial_core.c had a call to > >>>kgdb8250_add_port() from uart_add_one_port() and that didn't work for > >>>us anyway until the subsequent call to kgdb8250_add_platform_port() > >>>call was added to the platform code. I think we have several issues > >>>with this call: > > >>So when I was doing this originally, I found that things were a bit > >>sensitive to where/when stuff was called. My bet is that what happened > >>is that in the 5-6 kernel versions that have happened since, the call > >>order and/or meaning of things has changed, and we need to rework this > >>hook. > > > In my understanding, it's completely useless in its current form > >stuck anywhere in drivers/serial/ -- I mean using kgdb8250_add_port(), > >unless that latter function is changed. > > Maybe it was intended for the modular 8250 driver? This way, it should > make sense. But anyway, it (and/or driver itself) needs to be reworked WRT > of registering UARTs that the KGDB driver can't support, and probably > moving the hook into 8250 driver itself.
Ah yes, modular serial (and modular kgdb) are the cases I left out in describing things in the follow up to Vitaly. > BTW, is there plans to support something other than UPIO_PORT and > UPIO_MEM in 8250_kgdb.c? This mainly concerns UPIO_MEM32 and UPIO_AU (and > maybe UPIO_TSI which actually is the same as UPIO_MEM but masks couple of > the hardware issues with Tsi108 UART). At least the driver should filter > out unsupported UARTs, not treat them as UPIO_PORT like it does now... Patches or hardware donations accepted. I thought that once upon a time we did reject if it wasn't PORT or MEM, but that wasn't a tested code path, so perhaps it wasn't right or was dropped. -- Tom Rini ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Kgdb-bugreport mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
