Frederic Weisbecker wrote:
>> If it fails the debugger tried to remove it again later. It seems to
>> me like it is a don't care corner case. You get a printk if it ever
>> does happen (which it really shouldn't).
>
>
>
> Yeah truly it's a corner case, especially if the debugger can handle that
> later.
>
> May be just add a comment so that future reviewers don't stick to
> this part.
If you approve, I'll add your ack.
It looks like this now:
+static int hw_break_release_slot(int breakno)
+{
+ struct perf_event **pevent;
+ int cpu;
+
+ for_each_online_cpu(cpu) {
+ pevent = per_cpu_ptr(breakinfo[breakno].pev, cpu);
+ if (dbg_release_bp_slot(*pevent))
+ /*
+ * The debugger is responisble for handing the retry on
+ * remove failure.
+ */
+ return -1;
+ }
+ return 0;
+}
+
Thanks,
Jason.
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
