On Tue, Aug 14, 2018 at 08:46:01PM +0800, zhe...@windriver.com wrote:
> From: He Zhe <zhe...@windriver.com>
> 
> pr_* is preferred according to scripts/checkpatch.pl.
> 
> Cc: sta...@vger.kernel.org

This change does not "fix a problem that causes a build error
(but not for things marked CONFIG_BROKEN), an oops, a hang, data
corruption, a real security issue, or some “oh, that’s not good” issue.
In short, something critical.". Only the first patch meets this criteria
and only that patch should be Cc:ed to stable@ .

Please remove from this patch.


> Signed-off-by: He Zhe <zhe...@windriver.com>
> ---
> v2:
> - Split printk cleanups into a single patch
> - Add cc to sta...@vger.kernel.org
> 
>  drivers/tty/serial/kgdboc.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c
> index 206f8c2..0003d6c 100644
> --- a/drivers/tty/serial/kgdboc.c
> +++ b/drivers/tty/serial/kgdboc.c
> @@ -136,7 +136,7 @@ static int kgdboc_option_setup(char *opt)
>       }
>  
>       if (strlen(opt) >= MAX_CONFIG_LEN) {
> -             printk(KERN_ERR "kgdboc: config string too long\n");
> +             pr_err("kgdboc: config string too long\n");

Looks like you should remove the tags from pr_err and use pr_fmt(fmt) to
put tags on the messages:

#define pr_fmt(fmt) "kgdboc: " fmt


Daniel.

>               return -ENOSPC;
>       }
>       strcpy(config, opt);
> @@ -253,7 +253,7 @@ static int param_set_kgdboc_var(const char *kmessage,
>       int len = strlen(kmessage);
>  
>       if (len >= MAX_CONFIG_LEN) {
> -             printk(KERN_ERR "kgdboc: config string too long\n");
> +             pr_err("kgdboc: config string too long\n");
>               return -ENOSPC;
>       }
>  
> @@ -264,8 +264,7 @@ static int param_set_kgdboc_var(const char *kmessage,
>       }
>  
>       if (kgdb_connected) {
> -             printk(KERN_ERR
> -                    "kgdboc: Cannot reconfigure while KGDB is connected.\n");
> +             pr_err("kgdboc: Cannot reconfigure while KGDB is connected.\n");
>  
>               return -EBUSY;
>       }
> -- 
> 2.7.4
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport

Reply via email to