From 66d39c0de0abd45ddca7aa8fc08632b01d669d7b Mon Sep 17 00:00:00 2001
From: Wentao Wang <“witallw...@gmail.com”>
Date: Mon, 4 Mar 2019 21:58:33 +0800
Subject: [PATCH] Disable kgdboc failed by echo space to
 /sys/module/kgdboc/parameters/kgdboc
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Echo "" to /sys/module/kgdboc/parameters/kgdboc will fail with write
error: No such device
This is caused by function "configure_kgdboc" who init err to ENODEV when
the config is empty (legal input) the code go out with ENODEV returned.

Fixes: 2dd453168643d ("kgdboc: Fix restrict error")

Signed-off-by: Wentao Wang <“witallw...@gmail.com”>
---
 drivers/tty/serial/kgdboc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c
index 6fb312e..bfe5e9e 100644
--- a/drivers/tty/serial/kgdboc.c
+++ b/drivers/tty/serial/kgdboc.c
@@ -148,8 +148,10 @@ static int configure_kgdboc(void)
        char *cptr = config;
        struct console *cons;
 
-       if (!strlen(config) || isspace(config[0]))
+       if (!strlen(config) || isspace(config[0])) {
+               err = 0;
                goto noconfig;
+       }
 
        kgdboc_io_ops.is_console = 0;
        kgdb_tty_driver = NULL;
-- 
2.7.4


_______________________________________________
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport

Reply via email to