Hi, On Thu, Feb 13, 2020 at 8:42 AM Daniel Thompson <daniel.thomp...@linaro.org> wrote: > > Currently the PROMPT variable could be abused to provoke the printf() > machinery to read outside the current stack frame. Normally this > doesn't matter becaues md is already a much better tool for reading > from memory. > > However the md command can be disabled by not setting KDB_ENABLE_MEM_READ. > Let's also prevent PROMPT from being modified in these circumstances. > > Whilst adding a comment to help future code reviewers we also remove > the #ifdef where PROMPT in consumed. There is no problem passing an > unused (0) to snprintf when !CONFIG_SMP. > argument > > Reported-by: Wang Xiayang <xywang.s...@sjtu.edu.cn> > Signed-off-by: Daniel Thompson <daniel.thomp...@linaro.org> > --- > kernel/debug/kdb/kdb_main.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-)
I can't say I'm an expert on the kdb permissions model since I wasn't really even aware of it before reading this patch, but your change seems reasonable to me. Reviewed-by: Douglas Anderson <diand...@chromium.org> _______________________________________________ Kgdb-bugreport mailing list Kgdb-bugreport@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
