Hi,
On Mon, Mar 16, 2020 at 7:43 AM Dmitry Safonov <d...@arista.com> wrote:
>
> Print the stack trace with KERN_EMERG - it should be always visible.
>
> Playing with console_loglevel is a bad idea as there may be more
> messages printed than wanted. Also the stack trace might be not printed
> at all if printk() was deferred and console_loglevel was raised back
> before the trace got flushed.
>
> Unfortunately, after rebasing on commit 2277b492582d ("kdb: Fix stack
> crawling on 'running' CPUs that aren't the master"), kdb_show_stack()
> uses now kdb_dump_stack_on_cpu(), which for now won't be converted as it
> uses dump_stack() instead of show_stack().
>
> Convert for now the branch that uses show_stack() and remove
> console_loglevel exercise from that case.
>
> Cc: Daniel Thompson <daniel.thomp...@linaro.org>
> Cc: Douglas Anderson <diand...@chromium.org>
> Cc: Jason Wessel <jason.wes...@windriver.com>
> Cc: kgdb-bugreport@lists.sourceforge.net
> Signed-off-by: Dmitry Safonov <d...@arista.com>
> ---
> kernel/debug/kdb/kdb_bt.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
Presuming that the rest of this series is deemed acceptable by those
in charge, this patch looks fine to me:
Reviewed-by: Douglas Anderson <diand...@chromium.org>
-Doug
_______________________________________________
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
