Hi,

On Fri, Jul 9, 2021 at 3:44 AM Sumit Garg <sumit.g...@linaro.org> wrote:
>
> @@ -711,10 +711,10 @@ static int kdb_defcmd(int argc, const char **argv)
>                 struct kdb_macro_statement_t *kmc;
>
>                 list_for_each_entry(kp, &kdb_cmds_head, list_node) {
> -                       if (kp->cmd_func == kdb_exec_defcmd) {
> +                       if (kp->func == kdb_exec_defcmd) {
>                                 kdb_printf("defcmd %s \"%s\" \"%s\"\n",
> -                                          kp->cmd_name, kp->cmd_usage,
> -                                          kp->cmd_help);
> +                                          kp->name, kp->usage,
> +                                          kp->help);

The call could probably be squashed down to 2 lines instead of 3 now.


> @@ -1031,8 +1031,8 @@ int kdb_parse(const char *cmdstr)
>          */
>         if (list_entry_is_head(tp, &kdb_cmds_head, list_node)) {
>                 list_for_each_entry(tp, &kdb_cmds_head, list_node) {
> -                       if (strncmp(argv[0], tp->cmd_name,
> -                                   strlen(tp->cmd_name)) == 0)
> +                       if (strncmp(argv[0], tp->name,
> +                                   strlen(tp->name)) == 0)

Squash down to one line now that it's shorter.


The word wrapping isn't really a huge deal to me, though, so:

Reviewed-by: Douglas Anderson <diand...@chromium.org>


_______________________________________________
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport

Reply via email to