On Sat 2025-12-27 09:16:17, Marcos Paulo de Souza wrote: > The register_console_force function was introduced to register consoles > even on the presence of default consoles, replacing the CON_ENABLE flag > that was forcing the same behavior. > > No functional changes.
> --- a/fs/pstore/platform.c > +++ b/fs/pstore/platform.c > @@ -418,10 +418,10 @@ static void pstore_register_console(void) > sizeof(pstore_console.name)); > /* > * Always initialize flags here since prior unregister_console() > - * calls may have changed settings (specifically CON_ENABLED). > + * calls may have changed settings. > */ > - pstore_console.flags = CON_PRINTBUFFER | CON_ENABLED | CON_ANYTIME; > - register_console(&pstore_console); > + pstore_console.flags = CON_PRINTBUFFER | CON_ANYTIME; As the original comment suggests, this was done primary because of CON_ENABLED flag. Otherwise, the console was not registered again. register_console() might remove CON_PRINTBUFFER when there was a boot console and the newly registered console will get associated with /dev/console. But I consider this a corner case. Other console drivers ignore this scenario. I suggest to define the two flags statically in struct console pstore_console definition as it is done by other console drivers. Remove this explicit dynamic assigment. And add the following into the commit message: <proposal> Define the remaining console flags statically in the structure definition as it is done by other console drivers. The flags were re-defined primary because of the CON_ENABLED flag. Otherwise, the re-registration failed. The CON_PRINTBUFFER might get cleared when a boot console was registered and the pstrore console got associated with /dev/console. In this case, the pstore console would not re-play the entire ring buffer on re-registration. But it is a corner case. And it actually might be a desired behavior. </proposal> Otherwise, the next generations of kernel developers might think that the re-assigment was there because of CON_PRINTBUFFER flag. And it might cause non-necessary headaches ;-) > + register_console_force(&pstore_console); > } > > static void pstore_unregister_console(void) Best Regards, Petr
