On 23 October 2013 14:57, Dick Hollenbeck <d...@softplc.com> wrote: > > Brian, > > If it works for you, it works for me. I want your life as easy as > possible! Plus if it > works for you, it works for Windows users, and that brings them use of the > GITHUB_PLUGIN, > so I am happy all around. > > Hi Dick,
Excellent, I'm committed these changes in BZR4447 > IMO, it is also good for openssl. But you know how folks are with their > build systems. > (Folks like sticking with what they know.) > > Some comments: > > a) pcbnew/github/CMakeLists.txt will continue to use find_package( OpenSSL > REQUIRED ) on > linux. This is the path of least resistance for that platform. > > Agreed. > b) The path chosen on OSX seems unclear to me, but as written, > github/CMakeLists.txt will > route OSX builders to find_package() as well, meaning they will have to > install openssl in > advance of the build. I don't know OSX, the possibility to use your > openssl build system > is on the table, but just guessing, it seems they will prefer a pre-built > package like on > linux. > > c) You commented out the toolchain statement. I know Orson and others are > cross building > the entire KiCad for Windows on Linux. To me it seems we need to pass the > CMAKE_TOOLCHAIN_FILE setting in, on the assumption that if it is blank, it > won't break the > native build. You will confirm that upon re-enabling it. > > I commented this out because CMake barfs if you pass CMAKE_TOOLCHAIN_FILE as a blank value. I left it in, but commented out for exactly this sort of feedback. I've included it in a conditional which checks to see if CMAKE_TOOLCHAIN_FILE is blank. > d) Seems to need another new line at end of file, see very bottom. > > > > It builds on the excellent work you did on downloading > > and building openssl, > > I was passing the baton, knowing and hoping you'd step in and make it work > for the most > difficult platform. Trying to save you some initial work. > > You continue to be an MVP. > > Dick > > Excellent, this is now in place in BZR4447. KiCad-Winbuilder 3.1 (Literally minutes old) now includes support for the GAL default build as well as enabling FP_LIB_TABLE and GITHUB_PLUGIN so as to maximise the exposure of those features to beta-testers. There are easy-to-configure options in KiCad-Winbuilder to disable these options if someone wants to run the latest KiCad build without them enabled. We should now expect feedback on those features to increase. Thanks very much to Orson who did the changes necessary for KiCad-Winbuilder to successfully build the GAL code. A quick, simple merge was all that was necessary! Lovely! Now I'm looking forward to getting some boards done, and getting some work done on the regression testing too. Something other than build systems would be nice for a while! CMake continues to comfort me where autotools used to kick me in the shins regularly. The CMake documentation is also excellent, very complete and concise. Best Regards, Brian.
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
