----- Original Message ----- > From: jp charras <jp.char...@wanadoo.fr> > To: Cirilo Bernardo <cirilo_berna...@yahoo.com>; Ki Cad Developers > <kicad-developers@lists.launchpad.net> > Cc: > Sent: Friday, June 6, 2014 4:39 AM > Subject: Re: [Kicad-developers] [PATCH] IDF export rewritten > > Le 05/06/2014 08:30, Cirilo Bernardo a écrit : > >> I have rewritten the IDF export code to use the new IDF library. > Unfortunately the library is static at the moment since I can't get cmake to > link it and I just can't work out what's going wrong. >> >> Changes: >> + export_idf.cpp now uses the newer IDF code base. Except for better error >> reporting the users should not see anything new. However, the new code > base >> makes it trivial to extend the export routine if users have a need for >> exporting more IDF entities. This could be useful if/when other technical >> layers are implemented. >> >> + the old code (idf_common.cpp/h, idf.cpp/h) has been removed >> >> + some bugs in the IDF code have been fixed, including the map/multimap >> bug reported a few days ago. >> >> Testing: >> The export code was tested on 7 different existing projects of mine and > the >> output compared to the older code to ensure there were no unintended > differences. >> >> >> The patch name is 'kicad_idf_export.patch' and is available from: >> >> https://github.com/cbernardo/kicad-patches >> >> Next step: make the VRML exporter use the improved code in the idftools >> directory. >> >> cheers, >> Cirilo > > Committed. > Please, verify if this is OK. >
Thanks Jean-Pierre, I've built and tested the code and as far as I can see it behaves as expected. I will continue to check the code for a few more weeks; it is vital that it works correctly since I rely on it for my own work. - Cirilo _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp