… I initially did create the script with +x, but also it didn’t seem to survive commit/patch.
Regards, Bernhard On 08.12.2014, at 18:50, Johannes Maibaum <[email protected]> wrote: > I just realized that my patch won't really change the execute flag for > osx_build_wx.sh. I read from the bzr FAQs that normally the execute flag is > being tracked > (http://wiki.bazaar.canonical.com/FAQ #4.4). However, it seems that patches > cannot convey a > change to the flag of a file in the tree. The last line of my patch clearly > mentions the > change. > > Some quick checks show that neither patching with 'patch', nor with 'bzr > patch' (from > bzrtools) will change the flag. For classic 'patch' this seems OK, since they > explicitly state in their man file that file permission changes won't work. > But shouldn't it work > for bzr? I created the patch file with 'bzr diff', as suggested in > Documentation/HOW_TO_CONTRIBUTE.txt. > > I also tried to bzr rm the script and then re-add it with the correct > permissions. But > still, the execute flag won't survive within a patch. > > > Johannes > >> Am 08.12.2014 um 17:16 schrieb Andy Peters <[email protected]>: >> >> I also had to do the chmod +x on the osx_build_wx.sh script. > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
