-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi Nick,
Thank you for the help. I have no negative remarks to the patch, so it has been committed in 5318. I am surprised by the benchmark results, as both GAL & default renderer use the same code for zone filling. I wonder what else influences the speed, as I would not expect that rendering could make such a big difference. Regards, Orson On 12/08/2014 11:27 PM, Nick Østergaard wrote: > Hello > > This is an acompanion patch to the fill all patch accepted on the > bug tracker [1], implementing the same behaivour for GAL. You will > find the patch attached. > > I had to create a PCB_EDITOR_CONTROL::ZoneUnfillAll method. I think > I have done it correctly, it works at least. The GAL filling is > about 4.1 times faster than the default framework. Filling 4096 of > my random zones in about 25 seconds for default and about six > seconds for GAL. Please review. > > Maciej talked about doing with zone hiding/showing by using the > visibility buttons, but since [1] got accepted I decided to try > this out, and I think it work fairly good. > > I did not change the labels for the tool actions to match the ones > in the legacy patch, because the labels in GAL was short and > concise already. I don't have an opinion on that. > > Regards Nick Østergaard > > [1] https://bugs.launchpad.net/kicad/+bug/1084202 > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJUhisWAAoJEBRwGu1hpbJ1/eYH/0Zjx8QBecyXms5R8+F68Exg sowSygUPsTcrPuJxOLAHR8dYYXRO/KKkLjQgidkrNhzGx1KMPFni2vs2uQfV6rNT +Pngir5G/Q/44sZKRyvrdeY8//zLpOYV/zuX+wza5XXmndWtJZveSkFGrhohknN/ pj0bpl/gVn3Ak6ZAyG04AHwYdiE73ABMoT7SOO90uRIlfnt2+qrzGX6M0rEU6FcL U86b31KVRKhfRj84bBHszVDFrz4MX5rLslIGotZpg9lG6SJiZAmPAJ0NxXIe3HQv 3B4zhwtcyYfqdJZDbtCo6Dv9nNGjEEk8Tccf3xpGiVTfXfe3Sr8hd0ukCrIGPk4= =TEq6 -----END PGP SIGNATURE----- _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
