The problem this fixes will not be fixed by Henner's search dialog because the lag is due to the loading of the all footprints in the fp lib table. Henner's search dialog will need the entire list of footprint in order for the search to be effective. The footprint browser solves this problem because it uses lazy loading. I'll go ahead an commit the patch is unless someone objects.
On 6/21/2015 5:19 PM, Nick Østergaard wrote: > I think it is good. Mostly I click Select by Browser anyway. And if > Henner plans to move his awesome search as you type dialog to pcbnew > after the release I think it is ok. > > 2015-06-21 22:24 GMT+02:00 Wayne Stambaugh <stambau...@gmail.com>: >> Does anyone else have an opinion on this? Is there any objection to >> getting rid of the search dialog or do you prefer adding both a search >> (current dialog) and a browse (Chris's patch) option to select the >> footprint. I'm fine with either option. I want to be sure before I >> commit this patch. >> >> On 6/14/2015 4:30 PM, Chris Pavlina wrote: >>> This patch enables use of the new (kiface) footprint selector in the >>> "Exchange Footprints" dialog. >>> >>> As suggested in this bug report: >>> https://bugs.launchpad.net/kicad/+bug/1464821 >>> >>> I'll look into making this change in the module editor as well, but that >>> will require more work. >>> >>> -- >>> Chris >>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp