Hi Wayne, Here are my 2cents: - It is used (nothing much.. but used..), if you search for "pragma omp" https://github.com/KiCad/kicad-source-mirror/search?utf8=%E2%9C%93&q=pragma+omp&type=Code - I hope to use it much more in future for 3d-viewer... (and maybe some algorithms will really need it .. for real-time proposes..) - I believe it is however an optional thing.. but it will not build with multi processor support :/ (so if we really want sure they are build using openmp flag it must check if it is installed?) - Some time ago I was looking for some openMP presentations and I had idea that for gcc it is "embedded" (so yeah, probably you dont have to check it as a dependency).. I dont know how it works on other compilers..
"This appears to make OpenMP a dependency for building kicad?" Looking into: https://github.com/KiCad/kicad-source-mirror/blob/e87258510567cb95800178dec30b058c885c326c/CMakeLists.txt#L418 It doesn't like a dependency for me (Disclamer: I dont understand nothing of cmake.. ) but it looks like if openMP is found.. then it need to be / or can be added to the flags. As far as I know, gcc need the opemmp flag to be passed in order it to build supporting it.. MRL ________________________________________ From: Kicad-developers [[email protected]] on behalf of Wayne Stambaugh [[email protected]] Sent: 10 December 2015 13:30 To: Nick Østergaard Cc: KiCad Developers Subject: Re: [Kicad-developers] OpenMP patch He didn't add it, he just moved it out of the GCC specific configuration. I'm not sure why openmp would only be required when using gcc and not other compilers (which technically are not supported). Do we even need openmp? Where is used in KiCad? If we do need it, is it only required when building kicad with gcc? On 12/10/2015 8:26 AM, Nick Østergaard wrote: > It was added in the patch by the other Simon. > > https://github.com/KiCad/kicad-source-mirror/commit/e87258510567cb95800178dec30b058c885c326c#diff-af3b638bc2a3e6c650974192a53c7291 > > 2015-12-10 14:22 GMT+01:00 Wayne Stambaugh <[email protected]>: >> I'm not sure why openmp would be a dependency that is compiler >> dependent. I didn't add the openmp dependency so I cannot comment on >> why this would be specific to gcc. Anyone else know why openmp was gcc >> specific? >> >> On 12/9/2015 7:15 PM, Simon Wells wrote: >>> In BZR-6363 a patch was made so that OpenMP worked on non-gcc compilers >>> >>> >>> check_find_package_result( OPENMP_FOUND "OpenMP" ) >>> >>> Was also added, This appears to make OpenMP a dependency for building kicad? >>> >>> Is this meant to be the case or was this line added in error >>> >>> thanks >>> >>> Simon >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
