Chris, I'll commit the latest patch as is. You can tweak it as time goes by. This will also give other developers and users a chance to comment on it as well.
Technically there is no reason not to use the full resolution of eeschema (0.001") when placing the fields rather than using a fixed grid spacing. This way the field spacing could be flexible. Maybe you could use a fixed distance between each field so that no matter what the text height is, the spacing will always be constant. It's something to think about. On 12/12/2015 4:17 PM, Chris Pavlina wrote: > Wayne, would you rather I make this change and submit an updated monolithic > patch (will take a few days), or would you rather I make a second patch on > top of this one to be applied in a second commit? > > JP, the horizontal grid is already flexible, but the autoplacer doesn't do > vertical texts. How would that even work? It has to arrange them in a grid > somehow. Texts are always placed horizontally with respect to the sheet. > > > On Sat, Dec 12, 2015 at 07:43:47PM +0100, jp charras wrote: >> Le 12/12/2015 18:26, Chris Pavlina a écrit : >>> I actually thought a bit about that, and wasn't sure how to reconcile >>> "make the labels look nice" with "we like 50mil grids". But then, I went >>> off-grid for horizontal _anyway_, so... *shrug* >>> >>> It'll take some reworking of the placement code to make the vertical >>> grid flexible - not something I'd probably bother doing on my own, but >>> if other people want it, let me know and I'll have no problem >>> implementing that. >>> >> >> The 50 mils grid is good (read: mandatory) to place pins. >> So "we like this grid" for connected items (pins, labels, wires ..) >> >> But for graphics items a smaller grid is often needed. >> >> Fields can be seen as graphics items. >> I am thinking a smaller grid like 10 mils could be used to place them. >> >> (the horizontal grid should be also flexible, especially for vertical texts) >> >> Thanks. >> >> -- >> Jean-Pierre CHARRAS >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
