Hi, On 19.02.2016 18:27, jp charras wrote:
> Could you modify your changes to be compliant with our coding style > policy, when changing enum names? Sure -- do we really want enum names to be uppercase like class names, or is that going to lead to confusion? > Also can you group yours patches relative to the same thing (5 patches > to move an enum in a header and change its name is too much for me). Can do -- my goal was to keep the reviews short and independent -- applying them in order gives a working state after every patch, so if there is only time to look at one, this doesn't break anything, and as long as I keep them separately in my repository, I can also still easily rebase stuff in case one of them is rejected. The general direction I'm heading off is: - keep enum values in a header of at least similar name so they can be easily found - keep UI code (lookup of localized names and bitmaps) separate from data structures - create dedicated widget classes that initialize themselves and enforce typesafe accesses If all of these sound good, I can merge the changes to have fewer commits in total. Simon
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp