Okay, thanks for letting me know. If this was policy, I forgot about it. Do you want me to rework the patch to use wxUpdateUIEvent?
On Thu, Jan 05, 2017 at 08:57:14AM -0500, Wayne Stambaugh wrote: > Thanks Chris. In the future, please make sure that contributions use > wxUpdateUIEvent for updating UI states. A single code path for updating > UI element states prevents potential state conflicts when setting the > state in multiple wxCommandEvents. We have had issues with this in the > past where a UI element state would get toggled in one command event and > toggled again in a different command event causing the UI element state > to be incorrect. > > Cheers, > > Wayne > > On 1/4/2017 5:18 PM, Chris Pavlina wrote: > > Looks good to me, I pushed it. Thank you for your contribution to KiCad. > > > > It's easy for patches to slip through the cracks - in the future, don't > > be afraid to bump a patch a bit sooner, say within a week or two. > > Apologies for losing it. > > > > On Wed, Jan 04, 2017 at 07:45:40PM +0000, Diego Herranz wrote: > >> Hi, > >> > >> Did anyone have a chance to look at this? > >> > >> Many thanks. > >> > >> Regards, > >> Diego > >> > >> On Tue, Nov 22, 2016 at 8:10 AM, Diego Herranz < > >> [email protected]> wrote: > >> > >>> > >>> m_useGerberNetAttributes is useless if m_useGerberX2Attributes is not > >>> checked. > >>> So disabled (greyed out) when Gerber X2 gets unchecked to make it clear to > >>> the user. > >>> --- > >>> pcbnew/dialogs/dialog_plot.cpp | 20 ++++++++++++++++++++ > >>> pcbnew/dialogs/dialog_plot.h | 3 ++- > >>> pcbnew/dialogs/dialog_plot_base.cpp | 4 +++- > >>> pcbnew/dialogs/dialog_plot_base.fbp | 2 +- > >>> pcbnew/dialogs/dialog_plot_base.h | 3 ++- > >>> 5 files changed, 28 insertions(+), 4 deletions(-) > >>> > >>> > > > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : [email protected] > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
