Hi Jon, I see the point of your patch, as COMMON_ACTIONS are now a bit misused. They should not keep majority of the TOOL_ACTIONs, as many of them are pcbnew specific, but there are still actions that will be shared with other applications (e.g. zoom & grid control, move/rotate/flip).
For some time I was also wondering whether it would not be better to move the actions to their corresponding tools, as is done e.g. in pcbnew/router/router_tool.cpp (ACT_* objects), and leave only truly generic actions in {COMMON,PCB}_ACTIONS. What do you think about splitting the current set to PCB_ACTIONS and COMMON_ACTIONS, perhaps moving some of them to the tools source files? Regards, Orson On 02/17/2017 04:56 AM, Jon Evans wrote: > Hi all, > > More preparation for GerbView GAL port: this patch pulls a virtual ACTIONS > class out of pcbnew and renames the COMMON_ACTIONS to PCB_ACTIONS for > clarity. > > Best, > Jon > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp