Hey John, I pushed the fix. Thanks.
On 3/16/2017 10:38 AM, John Beard wrote: > Hi Wayne, > > Thanks for pushing. I don't see that in GTK+, but I'm told the > attached patch should do the right thing. > > These flags haven't been changed from the wxFB - was it also broken > before in Pcbnew? It was, I just didn't notice it until I saw the footprint editor display dialog. Cheers, Wayne > > Cheers, > > John > > On Thu, Mar 16, 2017 at 8:25 PM, Wayne Stambaugh <[email protected]> wrote: >> Hey John, >> >> I pushed your patches to the master branch. Thanks. One thing I >> noticed that I missed the first time around is the spin controls don't >> quite look right on windows (see attached image). Would you please take >> a look at this when you get a chance? >> >> Thanks, >> >> Wayne >> >> >> >> On 3/16/2017 6:24 AM, John Beard wrote: >>> Hi Wayne, >>> >>> Sorry about that, missed it as converting from wxFB's internal formatting. >>> >>> Updated patch 0001. >>> >>> Cheers, >>> >>> John >>> >>> On Thu, Mar 16, 2017 at 12:45 AM, Wayne Stambaugh <[email protected]> >>> wrote: >>>> Hey John, >>>> >>>> I like these changes but I noticed one minor coding policy issue. The >>>> macro _("") should be formatted as _( "" ). I'm willing to commit the >>>> patches as is and you can send a patch to fix the coding policy issues >>>> or you can revise the patches. I'm fine either way. >>>> >>>> Thanks, >>>> >>>> Wayne >>>> >>>> On 3/13/2017 12:35 PM, John Beard wrote: >>>>> Hi, >>>>> >>>>> Here is a patch set for a reusable GAL options panel, which allows any >>>>> GAL-aware program to set the GAL options in a dialog easily. >>>>> >>>>> This includes a new dialog for Modedit that uses the new panel, >>>>> closing the bug about not being able to change Modedit grid type. >>>>> >>>>> Gerbview's new GAL mode should be able to use this too. >>>>> >>>>> Third patch is a quick refactor for the Pcbnew display prefs panel, >>>>> which removes the old manual event handling and uses >>>>> TransferDataTo/FromWindow instead. >>>>> >>>>> Cheers, >>>>> >>>>> John >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>> Post to : [email protected] >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>> More help : https://help.launchpad.net/ListHelp >>>>> >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : [email protected] >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
