this is only a single #ifdef to default it to off as osx has been as long as i have been using it, its not compiling the icons out or anything
On 11 April 2017 at 07:12, Wayne Stambaugh <stambau...@gmail.com> wrote: > I thought the reason that we added this option is so that users could > choose if they wanted to show the icons in menus. I seem to remember > from the original discussion that some of our osx users didn't like the > fact that they were compiled out of osx builds. Do we really need to > add the ugly #if defined()/#endif code? > > As for the icon size, fixing that would likely not be trivial. A long > time ago we used 16 X 16 images but users were complaining that they > were too small as display resolution increased so we increased them to > 24 X 24. We could create an image library with multiple size images to > resolve this issue. > > On 4/8/2017 6:55 AM, Simon Wells wrote: >> also as noticed with this the icons seem overly huge for the menu, are >> they actually the right size on any platform? as on osx at least if you >> want the option there they should really be created at the right size so >> that it fits in with how tall a row should be in a menu rather than >> making each row huge as seen in screenshot >> >> >> >> >> On 8 April 2017 at 22:42, Simon Wells <swel...@gmail.com >> <mailto:swel...@gmail.com>> wrote: >> >> Please see attached patch to disable icons in the menus by default >> on osx >> >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp