Hi,
I am a little confused. What exactly is wrong with the patch? According
to the IRC discussion a while ago, I think it was with nickoe, the best
approach is probably to adopt the changes in FindwxWidgets and when
KiCAD upgrades to a reasonably new CMake, get rid of the KiCAD copy and
use the system one. Is there something I miss?
Honza
Dne 25.4.2017 v 17:08 Simon Richter napsal(a):
Hi,
On 25.04.2017 14:45, Wayne Stambaugh wrote:
Are you saying this patch will not work as is or are there other steps
we need to do to get this correct?
Neither. The patch is likely to work, I've scheduled a quick(...) test
for Windows in Jenkins to make sure of that.
I'm mainly passing on my experience in synchronizing our
FindwxWidgets.cmake to upstream -- last time I just submitted a bunch of
patches, but didn't talk about what I'd learned -- if you know where to
tweak the includes, you end up pulling out a lot less hair.
Simon
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
