Le 06/05/2017 à 07:35, Oliver Walters a écrit : > After feedback on the original thread > (https://lists.launchpad.net/kicad-developers/msg29057.html) > > I have made some further improvements to the component table: > > a) Add values from template fields where no value exists > b) Allow users to specify which fields are used for sorting (default = all > fields) > c) Add an "Apply changes" button which updates components accordingly > d) UI improvements > > Please find patches attached.
Thanks, Oliver for all this very good work. But your last patch is partially a regression: the ESC key does not work anymore. I suggest you to use the wxStdDialogButtonSizer container to manage OK, Cancel, Apply buttons (they are all standard buttons). This wxStdDialogButtonSizer container has many advantages for multi-platform applications (for instance look and fell). "Revert Changes" button must be managed outside this container. >From my point of view, confirmation when the dialog is closed should not occur >when clicking OK or Cancel button, only ESC key. However I am not sure if it is easy to manage ESC key and Cancel button with different options. -- Jean-Pierre CHARRAS _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
