great ! thanks a lot
Fabrizio On Mon, Jul 3, 2017 at 6:07 PM, Maciej Sumiński <maciej.sumin...@cern.ch> wrote: > Hi Fabrizio, > > No problem, it is already pushed (split into two commits). Thank you for > the patch! > > Cheers, > Orson > > On 07/03/2017 05:41 PM, Fabrizio Tappero wrote: >> Hi Maciej, >> yes please! >> >> I have been busy with some other patch and I could not find the time >> to get back to this one. I would it really appreciate if you could >> apply my patch including Weyne comments. Please mind that the same >> patch includes some copy icon fixes too. >> >> Cheers >> Fabrizio >> >> >> On Mon, Jul 3, 2017 at 4:51 PM, Maciej Sumiński <maciej.sumin...@cern.ch> >> wrote: >>> Hi Kristoffer, >>> >>> Thank you very much, I have just pushed your patch. I was really close >>> to implementing it myself, so I am glad you have done it. >>> >>> Other related changes I would like to introduce (open for discussion): >>> >>> - Proper naming for copy/duplicate operation (addressed by Fabrizio's >>> patch, I will simply rebase it and apply Wayne's remarks as it has been >>> reviewed already) >>> >>> - Rename constants to match the actions (BLOCK_COPY->BLOCK_DUPLICATE, >>> BLOCK_SAVE->BLOCK_COPY) >>> >>> - Remove the toolbar icons for cut/copy/paste. I am not sure if they are >>> even usable (with exception of Paste button). One cannot select a block >>> and move the mouse cursor out of the schematic frame to click the >>> toolbar buttons. >>> >>> - Add Paste operation in the right-click context menu when clipboard is >>> not empty. >>> >>> Regards, >>> Orson >>> >>> On 07/03/2017 01:51 PM, Kristoffer Ödmark wrote: >>>> Hey! >>>> >>>> I made the copy/paste/cut functionality work as someone new to the >>>> software might expect. That is, the cut command now actually puts the >>>> block in clipboard and then deletes the block, compared to just deleting >>>> it (wtf)? >>>> >>>> They are also bound to the almost universal defaults of ctrl+c/v/x. >>>> >>>> - Kristoffer >>>> >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : kicad-developers@lists.launchpad.net >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp >>>> >>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
