Hi Orson, I understand your concern; I will back out this patch and look at other ways of improving the behavior (the current behavior does not work very well at all in GerbView when zoomed in, but I could maybe set another factor for the variable line width for GerbView that would work better).
Actually in the back of my mind I think it might be nicer to highlight the shape of the item itself in the green color rather than its bounding box, but that's another matter... -Jon On Fri, Sep 15, 2017 at 3:02 PM, Maciej Suminski <maciej.sumin...@cern.ch> wrote: > Hi Jon, > > The implementation is correct, I tested the patch and it works as > advertised, but I am not sure if we really want to switch to fixed line > width for BRIGHT_BOX. Drawing a 10px wide outline looks fine at certain > zoom levels, but the items are covered with the outline when the view is > zoomed out too much. Perhaps a thinner line would work better here. The > original line width (size dependent) has been chosen to work as a well > visible outline for the most common track/pad/via sizes. > > Oliver, just to clarify: the method Jon used works on the same principle > as the one you had proposed. The difference is Jon applied it to an item > that is supposed to be displayed using a non-cached vertex container. > You have proposed a generic function (GAL::SetFixedLineWidth()) which > works correctly for non-cached items, but fails for cached items. This > is the sole reason why I have not applied your patch, as it would add a > method that works only under specific circumstances, whereas it needs to > work in all cases. As you have guessed correctly, there are too many > issues to fix now, so I could not really focus on this task. It is > almost done, but I am stuck with a few visual artifacts I could not fix > easily. > > Regards, > Orson > > On 09/06/2017 02:24 AM, Jon Evans wrote: > > Hi all, > > > > This patch is a quick one to make the line width of the BRIGHT_BOX > > dependent on the zoom level so that it remains basically the same > apparent > > size on the screen. > > > > -Jon > > > > > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp