It makes more sense to me to wait then, rather than duplicating efforts on non critical features.
Thanks On 19 Sep 2017 01:03, "Wayne Stambaugh" <stambau...@gmail.com> wrote: > Hey Oliver, > > I just tested your updates it seems to work OK except for the fact that > the fill color cannot be set to unspecified without manually editing the > config file. It would be nice (hint hint) if someone would add an > optional none color selection to our color selector dialog. > > I also thought of a one other major issue that I missed during my first > review. None of the plot formats support the sheet filling. I > confirmed this. I can almost guarantee that a bug report will be filed > on this not long after it gets packaged. I don't know how difficult > this will be to implement due to the fact that the fill state is > determined outside the sheet object itself where as for graphic objects > it is contained in the graphic item itself. > > I am a bit on the fence about this now that I've taken a closer look at > it. Sheet filling will be part of the new schematic file format which > will change the way this is defined in the future so there is that to > consider. If the plotting issues and color selection issues are > addressed by the time the 5 stable branch is created, then I would merge > this if there were no objections. If you or someone else cannot ensure > this, than I would prefer to hold off until after the stable 5 release. > > Cheers, > > Wayne > > On 9/14/2017 10:30 PM, Oliver Walters wrote: > > Wayne, > > > > Good point. The attached patch set modifies the default sheet background > > to UNSPECIFIED. > > > > Regarding the ability to unset the color. Any suggestions on how best to > > do this? I have played around with a few options without success. > > > > The best I came up with: > > > > Add a checkbox to the color selection window e.g. "Fill sheet > > background" which overrides the actual color selection. But I cannot > > find a way to pass this information to SCH_SHEET::Draw > > > > On Fri, Sep 15, 2017 at 12:22 AM, Wayne Stambaugh <stambau...@gmail.com > > <mailto:stambau...@gmail.com>> wrote: > > > > Oliver, > > > > I just tested this patch and I like it. I would like you to please > set > > the default color to COLOR4D::UNSPECIFIED if possible so that no > filling > > occurs unless the user selects a color. It is rather jarring to > > suddenly have all of the sheets in your schematic turn blue. It > might > > also be nice if you could select COLOR4D::UNSPECIFIED in the standard > > color selector for users who prefer no fill on sheets but that could > be > > in a separate patch. > > > > Wayne > > > > On 9/12/2017 5:11 AM, Oliver Walters wrote: > > > This small patch adds a configurable background color > for hierarchical > > > sheets. > > > > > > Image: http://i.imgur.com/53zgcy9.png <http://i.imgur.com/53zgcy9. > png> > > > > > > Oliver > > > > > > > > > _______________________________________________ > > > Mailing list: https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > > Post to : kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > > Unsubscribe : https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > > More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> > > > > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > Post to : kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > Unsubscribe : https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> > > > > >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp