Looks good to me. If there are no major objections I will merge this patch.
On 10/19/2017 11:53 AM, Kristoffer Ödmark wrote: > I tested the GetAssociatedDocument, works much better and has more > features so i took the freedom of updating the dialog windows to use > that instead of the wxLaunchDefaultBrowser as well > > attaching patch :) > > - Kristoffer > > On 10/19/2017 02:07 PM, Wayne Stambaugh wrote: >> On 10/19/2017 7:09 AM, Kristoffer Ödmark wrote: >>> Yes indeed it breaks that, I would argue that having an "invisible" >>> field opened when using the context field is the source of the >>> confusion. So I am aware it breaks the context menu for old schematics >>> but think it is necessary anyway. >> >> I'm OK with this change. I'm not sure why we would use the document >> field from the library symbol rather the schematic symbol. AFAIK, we >> don't do that for any other schematic symbol fields. >> >>> >>> I can of course use GetAssociatedDocument instead. >>> >>> On Oct 19, 2017 12:54 PM, "jp charras" <jp.char...@wanadoo.fr >>> <mailto:jp.char...@wanadoo.fr>> wrote: >>> >>> Le 18/10/2017 à 20:20, Kristoffer Ödmark a écrit : >>> > Glad to hear it, I fixed a patch up that will highlight the >>> differences a bit better than I explain it. >>> > >>> > Basically it will fill the field from the properties if the field >>> is empty when adding components to >>> > the schematic. >>> > >>> > It will also use the Field to determine when to show the context >>> menu instead of relying on the >>> > library. >>> > >>> > - Kristoffer >>> > >>> >>> Unfortunately, it breaks access to the associated document for >>> existing schematics, that can have a >>> datasheet name set in library, but not in schematic. >>> >>> and calling: >>> ::wxLaunchDefaultBrowser( text ); is incorrect >>> (text is not always a .pdf doc with a full absolute path or URI) >>> see: >>> GetAssociatedDocument() >>> >>> -- >>> Jean-Pierre CHARRAS >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> Post to : kicad-developers@lists.launchpad.net >>> <mailto:kicad-developers@lists.launchpad.net> >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >>> >>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp