Thank you. But I still get the same assert. All I do it hit d on my cap and move the pin anchor to the middle of the T junction where the one pin is on the same net.
2017-10-28 21:30 GMT+02:00 Seth Hillbrand <seth.hillbr...@gmail.com>: > Thank you Nick for testing! Looks like a missed a `break` when > re-formatting from the first commit. > > I've corrected the issue in the attached patch set. > > -Seth > > On Sat, Oct 28, 2017 at 5:49 AM, Nick Østergaard <oe.n...@gmail.com> > wrote: > >> Hello Seth >> >> I am not entirely sure what these patches actually do, but I tired to >> test them. >> >> But I have major problems with dragging stuff around in kicad. On the >> attached I dragged a capacitor to the T junction on the wire above it. >> >> If I make the asserts continue I get a blank page eventually. >> >> Nick >> >> >> >> 2017-10-28 <20%2017%2010%2028> 2:09 GMT+02:00 Seth Hillbrand < >> seth.hillbr...@gmail.com>: >> >>> Hi All- >>> >>> Quick ping on this. Master has moved on, so I've re-based the patch set >>> to the current master, in case anyone is up for looking at it. I also >>> split out the largest patch into a couple of logical blocks, in hopes of >>> making it easier to review. >>> >>> Lastly, I found and fixed a corner case where removing two segments on >>> the same junction broke the undo/redo stack. >>> >>> Thanks! >>> Seth >>> >>> On Mon, Oct 16, 2017 at 5:27 PM, Seth Hillbrand < >>> seth.hillbr...@gmail.com> wrote: >>> >>>> Attached is a proposed patchset for automatically managing junctions, >>>> adding and deleting them as they are needed by the schematic. >>>> >>>> The patches touch a number of sections, so any reports of issues would >>>> be greatly appreciated. Notably, this introduces an "append" feature to >>>> eeschema's undo save, which allows us to stack changes from different calls >>>> into the undo list. This removes the issue where "Delete Connection" would >>>> break the undo stack. >>>> >>>> Schematic cleanup is moved from the SCH_SCREEN class into the >>>> SCH_EDIT_FRAME class to provide access to the undo stack. >>>> >>>> Cleanup now checks for overlapping segments as well as duplicate >>>> junctions and merge-able lines. >>>> >>>> Bugs reports addressed by this patchset: >>>> https://bugs.launchpad.net/kicad/+bug/1563153 >>>> https://bugs.launchpad.net/kicad/+bug/593888 >>>> https://bugs.launchpad.net/kicad/+bug/1482111 >>>> >>>> Any feedback would be greatly appreciated. >>>> >>>> -S >>>> >>>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >>> >> > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp