Hello Maciej,
I have some comments:
First of all, it looks quite neat.
Secondly I noticed a small thing. When I open the symbol library editor and
it open in a small window and i resize it (make it bigger). The canvas
contains some resizing artefacts, but if I zoom on step with the scroll
whell and resize the window these aretefacts are not present. I am
guessing: Maybe something needs to be initialized, or maybe it only draws
the viewable area initially, but have a bigger area cached after a zoom
action.
Thirdly it seems strange to me that when I edit something (move a pin) and
try to close the editor it asks me to selct a library. Hmm, ok? The dialog
is named "Save Libraries", but there is no OK or cancel button. This is
stange and unexpected. This means that I can't really save or reject my
changes.
Fourthly, when I have multiple libs open, and I seach it seems to alway
unfold the last lib. I would probably have expected all libs with matches
in it being unfolded, such that I can see the entries I am searching for.
I tested 0431a6fc6ce128973308638c1011bc95049fb173 from your libedit branch
on archlinux.
Application: kicad
Version: (2017-11-20 revision 0431a6fc6)-HEAD, debug build
Libraries:
wxWidgets 3.0.3
libcurl/7.56.1 OpenSSL/1.1.0g zlib/1.2.11 libpsl/0.18.0 (+libicu/59.1)
libssh2/1.8.0 nghttp2/1.27.0
Platform: Linux 4.13.12-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
Boost: 1.65.1
Curl: 7.56.1
Compiler: GCC 7.2.0 with C++ ABI 1011
Build settings:
USE_WX_GRAPHICS_CONTEXT=OFF
USE_WX_OVERLAY=OFF
KICAD_SCRIPTING=ON
KICAD_SCRIPTING_MODULES=ON
KICAD_SCRIPTING_WXPYTHON=ON
KICAD_SCRIPTING_ACTION_MENU=ON
BUILD_GITHUB_PLUGIN=ON
KICAD_USE_OCE=OFF
KICAD_SPICE=ON
Nick
2017-11-20 16:20 GMT+01:00 Maciej Sumiński <maciej.sumin...@cern.ch>:
> It was not as difficult as I initially thought, meaning the libedit
> branch now also offers cut/copy/paste for graphical items in the library
> editor. There is nothing else I could add to the branch, so as long as
> there are no known bugs, I consider it ready for merging.
>
> Cheers,
> Orson
>
> On 11/18/2017 07:48 PM, Maciej Suminski wrote:
> > Thanks for the hug, but my girlfriend might become suspicious.
> > Apparently I am not the only one missing copy/paste in symbol editor,
> > but please do not hold your breath on this, as we still need you for
> > coding. I already have one copy/paste failure behind me, but it also
> > means that I know at least way of how it should *not* be implemented.
> > There should not be too many possible options, right?
> >
> > Cheers,
> > Orson
> >
> > On 11/18/2017 07:42 PM, Chris Pavlina wrote:
> >> Copy/paste in libedit? Finally? ...want a hug?
> >>
> >> On Sat, Nov 18, 2017 at 06:11:34PM +0000, Maciej Suminski wrote:
> >>> Hi Wayne,
> >>>
> >>> Lots of fun, sponsored by wxWidgets. I agree about not delaying the
> >>> feature freeze any more, I already feel a bit guilty. I believe the
> >>> library editor refactor is ready as it is, but I would appreciate some
> >>> test runs.
> >>>
> >>> In the meantime I am going to work on an additional feature
> >>> (copy/paste), but it is not mandatory to have it in the library editor,
> >>> as it has never been possible before. It is just a cherry on top of the
> >>> cake.
> >>>
> >>> Cheers,
> >>> Orson
> >>>
> >>> On 11/18/2017 04:57 PM, Wayne Stambaugh wrote:
> >>>> Orson,
> >>>>
> >>>> Are having fun yet? Let's tentatively aim for the end of next week to
> >>>> get it merged. I'm off most of next week for the Thanksgiving holiday
> >>>> so I should have time get some of the stuff I want to get done as
> well.
> >>>> If you are not confident you can get it ready by then, I fine with
> >>>> pushing it off until the stable 6 release. I would rather wait than
> try
> >>>> to rush to get it done an drag the stable 5 release out any further.
> >>>>
> >>>> Cheers,
> >>>>
> >>>> Wayne
> >>>>
> >>>> On 11/18/2017 08:35 AM, Maciej Suminski wrote:
> >>>>> Whew, I got the dynamic updates working both on Windows and Linux.
> There
> >>>>> are no more known issues that need fixing. I would like to merge the
> >>>>> branch in a few days if there are no more comments/requests.
> >>>>>
> >>>>> In the pipeline I still keep copy/paste for graphical items in the
> >>>>> symbol library editor. There is a chance I can finish it before the
> >>>>> feature freeze (==branch is merged), but I do not want to make it
> >>>>> another reason of delay. If things go smooth, copy/paste will be
> >>>>> included in v5, otherwise - v6.
> >>>>>
> >>>>> Regards,
> >>>>> Orson
> >>>>>
> >>>>> On 17/11/2017 11:03 PM, Maciej Suminski wrote:
> >>>>>> Thank you very much Simon, it should ease the testing process. I
> have
> >>>>>> already found out what is wrong with the dynamic update on Windows,
> but
> >>>>>> I am still working on a solution.
> >>>>>>
> >>>>>> Actually, if the installer was created today, the most likely it is
> a
> >>>>>> version with dynamic updates working correctly on Windows, but not
> on
> >>>>>> Linux. I am tempted to use #ifdefs, but I feel it is inappropriate.
> >>>>>>
> >>>>>> Regards,
> >>>>>> Orson
> >>>>>>
> >>>>>> On 11/17/2017 09:58 PM, Simon Richter wrote:
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>> On 14.11.2017 17:37, Maciej Sumiński wrote:
> >>>>>>>
> >>>>>>>> 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+
> ref/libedit
> >>>>>>>
> >>>>>>> Also known as
> >>>>>>>
> >>>>>>> http://downloads.kicad-pcb.org/windows/testing/patched/
> kicad-patched-18-10de79260-x86_64.exe
> >>>>>>>
> >>>>>>>
> >>>>>>> Simon
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> _______________________________________________
> >>>>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>>>> Post to : kicad-developers@lists.launchpad.net
> >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>>>> More help : https://help.launchpad.net/ListHelp
> >>>>>>>
> >>>>>>
> >>>>>> _______________________________________________
> >>>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>>> Post to : kicad-developers@lists.launchpad.net
> >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>>> More help : https://help.launchpad.net/ListHelp
> >>>>>>
> >>>>>
> >>>>> _______________________________________________
> >>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>> Post to : kicad-developers@lists.launchpad.net
> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>> More help : https://help.launchpad.net/ListHelp
> >>>>
> >>>> _______________________________________________
> >>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>> Post to : kicad-developers@lists.launchpad.net
> >>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>> More help : https://help.launchpad.net/ListHelp
> >>>>
> >>>
> >>> _______________________________________________
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help : https://help.launchpad.net/ListHelp
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help : https://help.launchpad.net/ListHelp
> >
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
>
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
