Seth, I merged you patch set into the development branch. Nice work and thank you for you contribution to KiCad.
Cheers, Wayne On 11/29/2017 2:14 PM, Seth Hillbrand wrote: > Here is the re-based patchset. No code changes but I repaired the > coding policy violations. > > Best- > Seth > > On Wed, Nov 29, 2017 at 7:40 AM, Wayne Stambaugh <stambau...@gmail.com > <mailto:stambau...@gmail.com>> wrote: > > Seth, > > I've done some minimal testing with this patch set and it appears to > work as expected. I like the way it handles junctions and it does > resolve the undo issue I was having with the overlapped wires/buses. I > am assuming this is the latest patch set and that there are no other > patches that need to be applied other than the patches attached to this > message. If no one objects, I will merge this. > > Thanks, > > Wayne > > On 11/27/2017 6:03 PM, Seth Hillbrand wrote: > > Hi Orson- > > > > Thanks for the pointer. I found and corrected the issue and updated the > > commit messages to remove the NEW/CHANGED tags that didn't reflect > > user-visible changes. > > > > Since we're now in feature freeze, this may be too late for 5.0. > > However, this does address a number of bug reports so I'm attaching the > > minimized patchset in case Wayne would like to merge it. If Wayne > > decides that this more feature/less bugfix, I'll hold onto the patchset > > until we have a 6-dev branch. > > > > Best- > > Seth > > > > On Sat, Nov 25, 2017 at 7:37 AM, Maciej Suminski > > <maciej.sumin...@cern.ch <mailto:maciej.sumin...@cern.ch> > <mailto:maciej.sumin...@cern.ch <mailto:maciej.sumin...@cern.ch>>> > wrote: > > > > Hi Seth, > > > > I tried this with interf_u demo shipped with the source code. There > are > > four capacitors in the left bottom corner - try dragging one of the > > middle ones out. If you cannot reproduce the problem, I will try to > > shoot a video. > > > > Cheers, > > Orson > > > > On 11/25/2017 03:58 PM, Seth Hillbrand wrote: > > > Hi Orson- > > > > > > Thanks for the test and the clarification of the documentation. > > > > > > On the schematic, I can't seem to recreate the issue you document > > in the > > > image. Is the example schematic one you can share? > > > > > > Best- > > > Seth > > > > > > On Fri, Nov 24, 2017 at 6:50 AM, Maciej Sumiński > > <maciej.sumin...@cern.ch <mailto:maciej.sumin...@cern.ch> > <mailto:maciej.sumin...@cern.ch <mailto:maciej.sumin...@cern.ch>>> > > > wrote: > > > > > >> Hi Seth, > > >> > > >> I tested the branch and I consider it a significant improvement > > to the > > >> way junctions are handled. I confirm it fixes the four bugs > > mentioned in > > >> patch 0011, apart from a single case when a parallel > component is > > >> dragged out. In this case junctions are not still not auto > > deleted (see > > >> [1], the rightmost picture "Junction is not auto deleted"), but > > at least > > >> the overlapping wires are merged. It is not a big deal IMHO, > > especially > > >> the patch set fixes a lot of other issues. > > >> > > >> It has not been stated explicitly, but I thought we will use > > >> NEW/REMOVE/CHANGE tags for listing changes that are > perceived by the > > >> user. Therefore: > > >> > > >> CHANGE: DeleteItem removes junctions that are no longer > needed. > > >> > > >> informs the user about an improvement, but: > > >> > > >> CHANGE: DeleteItemsInList shares the code for DeleteItem. > > >> > > >> seems to be too detailed and does not need to be reflected > in the > > user > > >> documentation. > > >> > > >> What do you think? I will try to come up with a short paragraph > > that can > > >> be added to the website to make things clear. > > >> > > >> Regards, > > >> Orson > > >> > > >> 1. > > >> https://launchpadlibrarian.net/213748651/KICAD%20-%20BUG% > <https://launchpadlibrarian.net/213748651/KICAD%20-%20BUG%> > > <https://launchpadlibrarian.net/213748651/KICAD%20-%20BUG% > <https://launchpadlibrarian.net/213748651/KICAD%20-%20BUG%>> > > >> 20REPORT%20-%20EESCHEMA%20-%20SOME%20DRAG%20ISSUES.jpg > > >> > > >> On 11/22/2017 09:07 PM, Seth Hillbrand wrote: > > >>> Updated patchset for this proposal, rebased to master. I've > > also updated > > >>> the commit messages to match the CHANGE:/NEW: format and added > > one new > > >> bug > > >>> from launchpad that this addresses. > > >>> > > >>> -Seth > > >>> > > >>> On Wed, Nov 8, 2017 at 3:59 AM, Nick Østergaard > > <oe.n...@gmail.com <mailto:oe.n...@gmail.com> > <mailto:oe.n...@gmail.com <mailto:oe.n...@gmail.com>>> > > >> wrote: > > >>> > > >>>> For that specific issue with the junction drawing, there is a > > patch in > > >> the > > >>>> thread "[Kicad-developers] [PATCH] Draw junctions last" > > >>>> > > >>>> 2017-11-03 13:12 GMT+01:00 Jon Evans <j...@craftyjon.com > <mailto:j...@craftyjon.com> > > <mailto:j...@craftyjon.com <mailto:j...@craftyjon.com>>>: > > >>>> > > >>>>> I looked at fixing this and some other related things, and > > decided to > > >>>>> just wait for the GAL port. There will need to be huge > > refactoring of > > >> the > > >>>>> eeschema draw code as part of that effort, so putting much > > effort into > > >>>>> making the wxDC drawing better seems not worth it. > > >>>>> > > >>>>> -Jon > > >>>>> > > >>>>> On Nov 3, 2017 00:08, "Kevin Cozens" <ke...@ve3syb.ca > <mailto:ke...@ve3syb.ca> > > <mailto:ke...@ve3syb.ca <mailto:ke...@ve3syb.ca>>> wrote: > > >>>>> > > >>>>> On 2017-11-02 06:31 PM, Seth Hillbrand wrote: > > >>>>> > > >>>>>> Please let me know if there are any additional issues or > > suggestions > > >> for > > >>>>>> improvement. > > >>>>>> > > >>>>> > > >>>>> How difficult would it be to have junctions draw last on > > schematics? > > >>>>> There is a minor negative visual effect when you have a > > component with > > >> one > > >>>>> end joined to a wire by a junction and you replace the > component. > > >>>>> > > >>>>> When you replace the component the pin of the component > is now > > seen > > >>>>> extending through the round disc of the junction to the > center > > of the > > >>>>> junction. I prefer to always see just the full round > disc of a > > junction > > >>>>> mark even if I have replaced a component since placing the > > junction. > > >>>>> > > >>>>> -- > > >>>>> Cheers! > > >>>>> > > >>>>> Kevin. > > >>>>> > > >>>>> http://www.ve3syb.ca/ |"Nerds make the shiny > things that > > >>>>> distract > > >>>>> Owner of Elecraft K2 #2172 | the mouth-breathers, and > > that's why > > >>>>> we're > > >>>>> | powerful!" > > >>>>> #include <disclaimer/favourite> | --Chris > Hardwick > > >>>>> > > >>>>> > > >>>>> _______________________________________________ > > >>>>> Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > <https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers>> > > >>>>> Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > > <mailto:kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net>> > > >>>>> Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > <https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers>> > > >>>>> More help : https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp> > > <https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp>> > > >>>>> > > >>>>> > > >>>>> > > >>>>> _______________________________________________ > > >>>>> Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > <https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers>> > > >>>>> Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > > <mailto:kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net>> > > >>>>> Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > <https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers>> > > >>>>> More help : https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp> > > <https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp>> > > >>>>> > > >>>>> > > >>>> > > >>>> _______________________________________________ > > >>>> Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > <https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers>> > > >>>> Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > > <mailto:kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net>> > > >>>> Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > <https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers>> > > >>>> More help : https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp> > > <https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp>> > > >>>> > > >>>> > > >>> > > >>> > > >>> > > >>> _______________________________________________ > > >>> Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > <https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers>> > > >>> Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > > <mailto:kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net>> > > >>> Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > <https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers>> > > >>> More help : https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp> > > <https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp>> > > >>> > > >> > > >> > > >> > > >> > > >> _______________________________________________ > > >> Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > <https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers>> > > >> Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > > <mailto:kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net>> > > >> Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > <https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers>> > > >> More help : https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp> > > <https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp>> > > >> > > >> > > > > > > > > > > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > > Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > > More help : https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp> > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > More help : https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp> > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp