You're right on the threshold I chose (somewhat arbitrarily). 5mm sounds decent. I made an intentional choice not to start scaling until it's quite necessary, because it's just simple bitmap scaling and on displays that are lower in DPI they _look_ scaled.
On Thu, Jan 11, 2018 at 09:53:52AM +0000, kristoffer Ödmark wrote: > I have 2560x1440, 24" screens, I think those qualifies as high DPI? > > The slider value is at 100, and the diag value is at 23. The icons are ish > 5mm large. > > But i guess that is uneccesary since It seems the scaling works as intended, > I was just doing it wrong, so no errors, sorry :) > > The scaling seems correct as well, 100 = 5mm, 150 = 7.5, 200 = 11, measured > with a tape measure, so variance in size is expected. > > > Application: kicad > Version: (2018-01-11 revision a5b3d8e57)-master, debug build > Libraries: > wxWidgets 3.0.3 > libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 > (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0 > Platform: Linux 4.9.74-2-MANJARO x86_64, 64 bit, Little endian, wxGTK > Build Info: > wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24 > Boost: 1.65.1 > Curl: 7.57.0 > Compiler: GCC 7.2.1 with C++ ABI 1011 > > Build settings: > USE_WX_GRAPHICS_CONTEXT=OFF > USE_WX_OVERLAY=OFF > KICAD_SCRIPTING=ON > KICAD_SCRIPTING_MODULES=ON > KICAD_SCRIPTING_WXPYTHON=ON > KICAD_SCRIPTING_ACTION_MENU=OFF > BUILD_GITHUB_PLUGIN=ON > KICAD_USE_OCE=ON > KICAD_SPICE=ON > > > On 2018-01-11 01:13, Chris Pavlina wrote: > > If your system DPI is already within a certain range it won't do > > anything. Are you using a high DPI display? If it's not scaled > > correctly, would you please share with me the diagnostic number reported > > by the scale slider in eeschema prefs as well as a rough indication of > > the icons' physical size? Thanks. > > > > On Wed, Jan 10, 2018 at 11:16:46PM +0000, kristoffer Ödmark wrote: > > > Tried the patch, didnt really notice anything different though, I guess > > > you > > > need to add some custom scaling for this to take effect? > > > > > > > > > On 2018-01-10 22:23, Chris Pavlina wrote: > > > > Sure, assign me to it. I should have time to work on it tonight or > > > > tomorrow. > > > > > > > > On Wed, Jan 10, 2018 at 04:20:21PM -0500, Wayne Stambaugh wrote: > > > > > FYI, the edit footprint dialog in Pcbnew is not sized properly (at > > > > > least > > > > > on windows) which I'm pretty sure is related to your recent HiDPI > > > > > work. > > > > > Do you want me to file a bug report for it? > > > > > > > > > > On 1/10/2018 2:01 PM, Chris Pavlina wrote: > > > > > > By the way, I'm going to go ahead and push this tonight-ish if > > > > > > nobody > > > > > > objects. I know it's on the big side, but due to my limited number > > > > > > of > > > > > > machines to test on I really want time for user feedback. I'll be > > > > > > around > > > > > > to put out any fires. > > > > > > > > > > > > On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote: > > > > > > > Rebased patch attached. > > > > > > > > > > > > > > On Tue, Jan 09, 2018 at 01:27:16PM +0000, Maciej Sumiński wrote: > > > > > > > > Hi Chris, > > > > > > > > > > > > > > > > The patch does not apply cleanly on the current master, would > > > > > > > > you rebase > > > > > > > > it? Thanks in advance. > > > > > > > > > > > > > > > > Cheers, > > > > > > > > Orson > > > > > > > > > > > > > > > > On 01/09/2018 03:43 AM, Chris Pavlina wrote: > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > As discussed with Wayne earlier, I've attached a patch which > > > > > > > > > adds simple > > > > > > > > > toolbar icon scaling so the toolbars are readable on high-DPI > > > > > > > > > systems. > > > > > > > > > > > > > > > > > > This is meant as a stopgap for 5.0, with plans to add proper > > > > > > > > > scaled > > > > > > > > > icons in the 6.0 cycle. A function KiScaledBitmap() is added, > > > > > > > > > which > > > > > > > > > works like KiBitmap() except it scales the bitmap according > > > > > > > > > to the > > > > > > > > > calling window's font size. Controls have been added to all > > > > > > > > > the main > > > > > > > > > applications to let the user select scaling manually (these > > > > > > > > > were omitted > > > > > > > > > from smaller apps that didn't already have a place to put > > > > > > > > > them). > > > > > > > > > > > > > > > > > > In addition, in eeschema only, the pixel height of the system > > > > > > > > > font is > > > > > > > > > shown in the options dialog for diagnostics. This is only for > > > > > > > > > collecting > > > > > > > > > feedback before 5.0 release from users with different > > > > > > > > > displays and will > > > > > > > > > be removed. > > > > > > > > > > > > > > > > > > I would like to push this fairly soon, as I want to get as > > > > > > > > > much user > > > > > > > > > feedback as possible before release. I have a limited number > > > > > > > > > of systems > > > > > > > > > to test this on myself. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > Mailing list: https://launchpad.net/~kicad-developers > > > > > > > > > Post to : kicad-developers@lists.launchpad.net > > > > > > > > > Unsubscribe : https://launchpad.net/~kicad-developers > > > > > > > > > More help : https://help.launchpad.net/ListHelp > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > Mailing list: https://launchpad.net/~kicad-developers > > > > > > Post to : kicad-developers@lists.launchpad.net > > > > > > Unsubscribe : https://launchpad.net/~kicad-developers > > > > > > More help : https://help.launchpad.net/ListHelp > > > > > > > > > > > _______________________________________________ > > > > > Mailing list: https://launchpad.net/~kicad-developers > > > > > Post to : kicad-developers@lists.launchpad.net > > > > > Unsubscribe : https://launchpad.net/~kicad-developers > > > > > More help : https://help.launchpad.net/ListHelp > > > > _______________________________________________ > > > > Mailing list: https://launchpad.net/~kicad-developers > > > > Post to : kicad-developers@lists.launchpad.net > > > > Unsubscribe : https://launchpad.net/~kicad-developers > > > > More help : https://help.launchpad.net/ListHelp > > > > > > _______________________________________________ > > > Mailing list: https://launchpad.net/~kicad-developers > > > Post to : kicad-developers@lists.launchpad.net > > > Unsubscribe : https://launchpad.net/~kicad-developers > > > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp