Am 17.03.2018 um 20:21 schrieb Carsten Schoenert: > Is this somehow intended that these needed macros are removed in the > file common/dialog_about/AboutDialog_main.cpp? > Are there any more files to look at? > > Btw: The hyperlink to the libraries needs too be reworked too.
I'm answering myself and adding two patches that adding back the i18n strings. -- Regards Carsten Schoenert
>From 9c7b75807df13dcfb87966e164cbf506c1f5ae80 Mon Sep 17 00:00:00 2001 From: Carsten Schoenert <c.schoen...@t-online.de> Date: Sun, 18 Mar 2018 10:26:55 +0100 Subject: [PATCH 1/2] AboutDialog_main.cpp: re-adding i18n macros Some strings in the About Kicad dialog are not displayed as translated strings due the strings not marked as i18n based strings. --- common/dialog_about/AboutDialog_main.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/common/dialog_about/AboutDialog_main.cpp b/common/dialog_about/AboutDialog_main.cpp index 7c780d064..dd40d3bc3 100644 --- a/common/dialog_about/AboutDialog_main.cpp +++ b/common/dialog_about/AboutDialog_main.cpp @@ -129,16 +129,16 @@ static void buildKicadAboutBanner( EDA_BASE_FRAME* aParent, ABOUT_APP_INFO& aInf // bullet-ed list with some http links description << "<ul>"; description << "<li>" - << "The official KiCad website - " + << _( "The official KiCad website - " ) << HtmlHyperlink( "http://www.kicad-pcb.org" ) << "</li>"; description << "<li>" - << "Developer website on Launchpad - " + << _( "Developer website on Launchpad - " ) << HtmlHyperlink( "https://launchpad.net/kicad" ) << "</li>"; description << "<li>" - << "Official KiCad library repositories - " + << _(" Official KiCad library repositories - " ) << HtmlHyperlink( "https://github.com/KiCad/" ) << "</li>"; @@ -151,7 +151,7 @@ static void buildKicadAboutBanner( EDA_BASE_FRAME* aParent, ABOUT_APP_INFO& aInf // bullet-ed list with some http links description << "<ul>"; description << "<li>" - << "Report or examine bugs - " + << _( "Report or examine bugs - " ) << HtmlHyperlink( "https://bugs.launchpad.net/kicad/+bugs?orderby=-id&start=0", "https://bugs.launchpad.net/kicad" ) << "</li>"; @@ -163,12 +163,12 @@ static void buildKicadAboutBanner( EDA_BASE_FRAME* aParent, ABOUT_APP_INFO& aInf description << "<ul>"; description << "<li>" - << "KiCad forum - " + << _( "KiCad forum - " ) << HtmlHyperlink( "https://forum.kicad.info" ) << "</li>"; description << "<li>" - << "KiCad user's group - " + <<_( "KiCad user's group - " ) << HtmlHyperlink( "https://groups.yahoo.com/neo/groups/kicad-users/info" ) << "</li>"; -- 2.16.2
>From abf90f16a6c423a24abefb71673ba571124e8098 Mon Sep 17 00:00:00 2001 From: Carsten Schoenert <c.schoen...@t-online.de> Date: Sun, 18 Mar 2018 10:31:13 +0100 Subject: [PATCH 2/2] AboutDialog_main.cpp: update the link to the libraries The KiCad official libraries have now a own dedicated website. --- common/dialog_about/AboutDialog_main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/dialog_about/AboutDialog_main.cpp b/common/dialog_about/AboutDialog_main.cpp index dd40d3bc3..b58f6f3c0 100644 --- a/common/dialog_about/AboutDialog_main.cpp +++ b/common/dialog_about/AboutDialog_main.cpp @@ -139,7 +139,7 @@ static void buildKicadAboutBanner( EDA_BASE_FRAME* aParent, ABOUT_APP_INFO& aInf description << "<li>" << _(" Official KiCad library repositories - " ) - << HtmlHyperlink( "https://github.com/KiCad/" ) + << HtmlHyperlink( "https://kicad.github.io" ) << "</li>"; description << "</ul></p>"; -- 2.16.2
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp