Inspired by the discussion on bug 1771424<https://bugs.launchpad.net/kicad/+bug/1771424> I have made some small tweaks to the strings to hopefully improve the clarity on the way the tool works for users. As a non native speaker this is always a bit tricky so I'm happy to take suggestions if someone has better wording in mind.
Robbert
From df007df15ea66b26e6644c70dfb0c6e655a6b216 Mon Sep 17 00:00:00 2001 From: Unknown <rlagerw...@hotmail.com> Date: Sun, 20 May 2018 21:03:33 +0200 Subject: [PATCH] pcbnew: move exactly dialog tweaks Clarify some texts to remove ambiguity on the functioning of the tool. Updated dialog title. --- pcbnew/dialogs/dialog_move_exact_base.cpp | 12 ++++++++---- pcbnew/dialogs/dialog_move_exact_base.fbp | 16 ++++++++-------- pcbnew/dialogs/dialog_move_exact_base.h | 4 ++-- 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/pcbnew/dialogs/dialog_move_exact_base.cpp b/pcbnew/dialogs/dialog_move_exact_base.cpp index fe3c8b8..eb309de 100644 --- a/pcbnew/dialogs/dialog_move_exact_base.cpp +++ b/pcbnew/dialogs/dialog_move_exact_base.cpp @@ -1,5 +1,5 @@ /////////////////////////////////////////////////////////////////////////// -// C++ code generated with wxFormBuilder (version Aug 4 2017) +// C++ code generated with wxFormBuilder (version May 20 2018) // http://www.wxformbuilder.org/ // // PLEASE DO "NOT" EDIT THIS FILE! @@ -59,6 +59,8 @@ DIALOG_MOVE_EXACT_BASE::DIALOG_MOVE_EXACT_BASE( wxWindow* parent, wxWindowID id, m_rotLabel = new wxStaticText( this, wxID_ANY, _("Item rotation:"), wxDefaultPosition, wxDefaultSize, 0 ); m_rotLabel->Wrap( -1 ); + m_rotLabel->SetToolTip( _("Rotation is applied after the move and around the anchor") ); + fgInputSizer->Add( m_rotLabel, 0, wxALIGN_CENTER_VERTICAL|wxALIGN_RIGHT|wxALL, 5 ); m_rotEntry = new TEXT_CTRL_EVAL( this, wxID_ANY, _("0"), wxDefaultPosition, wxDefaultSize, 0 ); @@ -76,7 +78,7 @@ DIALOG_MOVE_EXACT_BASE::DIALOG_MOVE_EXACT_BASE( wxWindow* parent, wxWindowID id, wxString m_originChooserChoices[] = { _("Current position"), _("User origin"), _("Grid origin"), _("Drill/Place origin"), _("Sheet origin") }; int m_originChooserNChoices = sizeof( m_originChooserChoices ) / sizeof( wxString ); - m_originChooser = new wxRadioBox( this, wxID_ANY, _("Move Relative To:"), wxDefaultPosition, wxDefaultSize, m_originChooserNChoices, m_originChooserChoices, 1, wxRA_SPECIFY_COLS ); + m_originChooser = new wxRadioBox( this, wxID_ANY, _("Move Start Point:"), wxDefaultPosition, wxDefaultSize, m_originChooserNChoices, m_originChooserChoices, 1, wxRA_SPECIFY_COLS ); m_originChooser->SetSelection( 0 ); bMiddleSizer->Add( m_originChooser, 0, wxALL, 5 ); @@ -85,10 +87,12 @@ DIALOG_MOVE_EXACT_BASE::DIALOG_MOVE_EXACT_BASE( wxWindow* parent, wxWindowID id, bAnchorSizer = new wxBoxSizer( wxHORIZONTAL ); - m_cbOverride = new wxCheckBox( this, wxID_ANY, _("Override default footprint anchor with:"), wxDefaultPosition, wxDefaultSize, 0 ); + m_cbOverride = new wxCheckBox( this, wxID_ANY, _("Override default anchor with:"), wxDefaultPosition, wxDefaultSize, 0 ); + m_cbOverride->SetToolTip( _("By default the center of the selected item(s) will be positioned on the selected location. For footprints the default anchor is determined by the designer. ") ); + bAnchorSizer->Add( m_cbOverride, 1, wxALL, 5 ); - wxString m_anchorChoiceChoices[] = { _("Top left pad"), _("Footprint center") }; + wxString m_anchorChoiceChoices[] = { _("Top left pad"), _("Center point") }; int m_anchorChoiceNChoices = sizeof( m_anchorChoiceChoices ) / sizeof( wxString ); m_anchorChoice = new wxChoice( this, wxID_ANY, wxDefaultPosition, wxDefaultSize, m_anchorChoiceNChoices, m_anchorChoiceChoices, 0 ); m_anchorChoice->SetSelection( 0 ); diff --git a/pcbnew/dialogs/dialog_move_exact_base.fbp b/pcbnew/dialogs/dialog_move_exact_base.fbp index cbb91c3..7f90100 100644 --- a/pcbnew/dialogs/dialog_move_exact_base.fbp +++ b/pcbnew/dialogs/dialog_move_exact_base.fbp @@ -44,10 +44,10 @@ <property name="minimum_size">-1,-1</property> <property name="name">DIALOG_MOVE_EXACT_BASE</property> <property name="pos"></property> - <property name="size">427,250</property> + <property name="size">527,307</property> <property name="style">wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER</property> <property name="subclass">DIALOG_SHIM; dialog_shim.h</property> - <property name="title">Move Item</property> + <property name="title">Move Exactly</property> <property name="tooltip"></property> <property name="window_extra_style"></property> <property name="window_name"></property> @@ -194,7 +194,7 @@ <property name="border">5</property> <property name="flag">wxALL|wxBOTTOM|wxEXPAND|wxTOP</property> <property name="proportion">1</property> - <object class="wxFlexGridSizer" expanded="0"> + <object class="wxFlexGridSizer" expanded="1"> <property name="cols">4</property> <property name="flexible_direction">wxBOTH</property> <property name="growablecols">1</property> @@ -949,7 +949,7 @@ <property name="style"></property> <property name="subclass"></property> <property name="toolbar_pane">0</property> - <property name="tooltip"></property> + <property name="tooltip">Rotation is applied after the move and around the center of the selection</property> <property name="window_extra_style"></property> <property name="window_name"></property> <property name="window_style"></property> @@ -1276,7 +1276,7 @@ <property name="gripper">0</property> <property name="hidden">0</property> <property name="id">wxID_ANY</property> - <property name="label">Move Relative To:</property> + <property name="label">Move Start Point:</property> <property name="majorDimension">1</property> <property name="max_size"></property> <property name="maximize_button">0</property> @@ -1377,7 +1377,7 @@ <property name="gripper">0</property> <property name="hidden">0</property> <property name="id">wxID_ANY</property> - <property name="label">Override default footprint anchor with:</property> + <property name="label">Override default anchor with:</property> <property name="max_size"></property> <property name="maximize_button">0</property> <property name="maximum_size"></property> @@ -1398,7 +1398,7 @@ <property name="style"></property> <property name="subclass"></property> <property name="toolbar_pane">0</property> - <property name="tooltip"></property> + <property name="tooltip">By default the center of the selected item(s) will be positioned on the selected location. For footprints the default anchor is determined by the designer. </property> <property name="validator_data_type"></property> <property name="validator_style">wxFILTER_NONE</property> <property name="validator_type">wxDefaultValidator</property> @@ -1450,7 +1450,7 @@ <property name="caption"></property> <property name="caption_visible">1</property> <property name="center_pane">0</property> - <property name="choices">"Top left pad" "Footprint center"</property> + <property name="choices">"Top left pad" "Center point"</property> <property name="close_button">1</property> <property name="context_help"></property> <property name="context_menu">1</property> diff --git a/pcbnew/dialogs/dialog_move_exact_base.h b/pcbnew/dialogs/dialog_move_exact_base.h index 29db628..88758d6 100644 --- a/pcbnew/dialogs/dialog_move_exact_base.h +++ b/pcbnew/dialogs/dialog_move_exact_base.h @@ -1,5 +1,5 @@ /////////////////////////////////////////////////////////////////////////// -// C++ code generated with wxFormBuilder (version Aug 4 2017) +// C++ code generated with wxFormBuilder (version May 20 2018) // http://www.wxformbuilder.org/ // // PLEASE DO "NOT" EDIT THIS FILE! @@ -74,7 +74,7 @@ class DIALOG_MOVE_EXACT_BASE : public DIALOG_SHIM public: - DIALOG_MOVE_EXACT_BASE( wxWindow* parent, wxWindowID id = wxID_ANY, const wxString& title = _("Move Item"), const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize( 427,250 ), long style = wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER ); + DIALOG_MOVE_EXACT_BASE( wxWindow* parent, wxWindowID id = wxID_ANY, const wxString& title = _("Move Exactly"), const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize( 527,307 ), long style = wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER ); ~DIALOG_MOVE_EXACT_BASE(); }; -- 2.7.4
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp