I suppose this will be acceptable. Please make sure you use the same string as tracePathsAndFiles for consistency.
I'm wondering if it makes more sense to show the user an error dialog with a list of the missing model paths before creating the step file. I wonder why this was originally a debug message rather than a user error message. I would want to know that I have missing model paths and what they were so I could go back an fix any broken 3D model definitions. On 5/21/2018 9:41 AM, Jeff Young wrote: > Perhaps we should just change tracePathsAndFiles to a #define for now? > > >> On 21 May 2018, at 14:09, Wayne Stambaugh <[email protected]> wrote: >> >> I'm getting the following link error on windows builds after commit >> 10ec39a1. I looks like kicad2step is not being linked to the static >> common library. >> >> CMakeFiles/kicad2step.dir/objects.a(3d_resolver.cpp.obj):3d_resolver.cpp:(.rdata$.refptr.tracePathsAndFiles[.refptr.tracePathsAndFiles]+0x0): >> undefined reference to `tracePathsAndFiles' >> collect2.exe: error: ld returned 1 exit status >> make[2]: *** [utils/kicad2step/CMakeFiles/kicad2step.dir/build.make:289: >> utils/kicad2step/kicad2step.exe] Error 1 >> make[1]: *** [CMakeFiles/Makefile2:3018: >> utils/kicad2step/CMakeFiles/kicad2step.dir/all] Error 2 >> make[1]: *** Waiting for unfinished jobs.... >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
