Hi, Here are a handful of tiny fixes for warnings in the eeschema GAL branch. Nothing really controversial, I think (though the second one fixes quite a verbose tranche of warnings - one for almost every type of object :-).
Cheers, John On Tue, Sep 18, 2018 at 12:35 AM Jeff Young <j...@rokeby.ie> wrote: > > There’s a setting for that (Always show crosshairs). You probably have it on > in Pcbnew/Display Options but not in Eeschema/Display Options. > > > On 18 Sep 2018, at 00:30, Wayne Stambaugh <stambau...@gmail.com> wrote: > > > > I don't know if this is intentional or not but I noticed (at least on > > windows) that the cursor is no longer displayed when the select tool is > > active. This is different than the old canvas where the cursor always > > tracked the mouse point for all tools. > > > > Cheers, > > > > Wayne > > > > On 9/17/2018 7:21 PM, Jeff Young wrote: > >> I pushed fixes for sheet pins and the cursor. (It also removes a bunch of > >> legacy grid and cursor colour stuff that is no longer needed.) > >> > >> Cheers, > >> Jeff. > >> > >> > >>> On 17 Sep 2018, at 20:03, mdoes...@xs4all.nl wrote: > >>> > >>> I don't think I mailed the list, but also found another issue. > >>> > >>> I noticed the sheet text is the same color as "notes", and not "sheet > >>> label". > >>> > >>> The cursor cross-hair is always black. > >>> > >>> Otherwise it works fine for me on a quick test. > >>> > >>> regards, > >>> > >>> Mark. > >> > >> > >> _______________________________________________ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > >> > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp
From 062377a66836c02b38f58fd6daa6fc12b4b624f3 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Tue, 18 Sep 2018 14:41:06 +0100 Subject: [PATCH 2/3] Add default case in edit_label.cpp (-Wswitch) This should never ben hit as it's defended against above, but lack of a default causes lots of -Wswitch warnings, so add an assert and a return. --- eeschema/edit_label.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/eeschema/edit_label.cpp b/eeschema/edit_label.cpp index 8fca11b0e..b6da029b3 100644 --- a/eeschema/edit_label.cpp +++ b/eeschema/edit_label.cpp @@ -186,6 +186,10 @@ void SCH_EDIT_FRAME::OnConvertTextType( wxCommandEvent& aEvent ) case SCH_TEXT_T: newtext = new SCH_TEXT( position, txt ); break; + + default: + wxASSERT_MSG( false, wxString::Format( "Invalid text type: %d.", type ) ); + return; } /* Copy the old text item settings to the new one. Justifications are not copied because -- 2.18.0
From e1e4a9ff307bbe01bb60ecee673b717fd51e2e32 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Tue, 18 Sep 2018 14:45:52 +0100 Subject: [PATCH 3/3] Fix -Wreorder warning in common view-overlay.cpp Simple fix - m_radius comes after m_{start,end}Angle in the class member list. --- common/view/view_overlay.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/view/view_overlay.cpp b/common/view/view_overlay.cpp index a09734985..78543a156 100644 --- a/common/view/view_overlay.cpp +++ b/common/view/view_overlay.cpp @@ -77,9 +77,9 @@ struct VIEW_OVERLAY::COMMAND_ARC : public VIEW_OVERLAY::COMMAND { COMMAND_ARC( const VECTOR2D& aCenter, double aRadius, double aStartAngle, double aEndAngle ) : m_center(aCenter), - m_radius(aRadius), m_startAngle( aStartAngle ), - m_endAngle( aEndAngle ) + m_endAngle( aEndAngle ), + m_radius(aRadius) {} virtual void Execute( VIEW* aView ) const override -- 2.18.0
From 9b14e5fc6577e2b08252281d9960b8198c62f008 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Tue, 18 Sep 2018 14:30:23 +0100 Subject: [PATCH 1/3] Remove unused variable from pcbnew/onrightclick.cpp --- pcbnew/onrightclick.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/pcbnew/onrightclick.cpp b/pcbnew/onrightclick.cpp index a01d92673..4c0f30a54 100644 --- a/pcbnew/onrightclick.cpp +++ b/pcbnew/onrightclick.cpp @@ -393,8 +393,6 @@ bool PCB_EDIT_FRAME::OnRightClick( const wxPoint& aMousePos, wxMenu* aPopMenu ) case ID_NO_TOOL_SELECTED: { - wxMenu* commands = new wxMenu; - if( !trackFound ) { msg = AddHotkeyName( _( "Begin Track" ), g_Board_Editor_Hotkeys_Descr, HK_ADD_NEW_TRACK ); -- 2.18.0
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp