I haven't had a chance to review this patch yet. It's on my to do list. Until 5.1 is tagged and branched, no file format changes are allowed. Once the v6 development window opens, this patch will be up for consideration.
Cheers, Wayne On 11/6/2018 4:46 PM, Mário Luzeiro wrote: > Hi Oliver, > I was about to bump your email too :) > >> 2) The m_Preview parameter is saved to file (both .kicad_mod and .kicad_pcb) > > At the time I worked on the 3D Viewer, some ideas arise that involve to add > new tags to the .kicad_pcb > I understood that at that time it was not a good time to introduce changes on > the format files, special because as the stable release was approaching.. > > So, for this patch, I think the main question is if it is possible to > introduce new tags on the file formats. > > Nice to see someone adding new features related to the 3D Viewer! > > Regards, > Mario Luzeiro > > ________________________________________ > From: Kicad-developers > <kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net> on behalf of > Oliver Walters <oliver.henry.walt...@gmail.com> > Sent: 06 November 2018 21:18:20 > To: KiCad Developers > Subject: Re: [Kicad-developers] [PATCH] Option to not render 3D models for > footprints > > Bump :) > > On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters > <oliver.henry.walt...@gmail.com<mailto:oliver.henry.walt...@gmail.com>> wrote: > The attached patchset expands on the "Preview" checkbox in the 3D model tab > in the footprint editor. > > This "Preview" option currently only applies to the preview window. However > if the user wishes to disable display of a given 3D model in the PCB renderer > they must delete the 3D model from the footprint entirely. > > The new patchset does the following: > > 1) The state of the m_Preview parameter for each 3D model is observed in the > various 3D renderers and exporters > > 2) The m_Preview parameter is saved to file (both .kicad_mod and .kicad_pcb) > > With regard to file saving, if the 3D model is "enabled" (default state) then > the file is unchanged making this change largely backwards compatible. If the > 3D model is disabled, then the keyword "(disabled)" is added to the file. > > You can now quickly toggle 3D models on/off on an individual basis and this > is statefully saved between sessions. > > Patch-set is rebased and compiled from > b445b0fab28f7dd41273801d06d7705215c57c0f > > Regards, > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
