Stefan,
I tested you patch and it seems to work fine on linux. However, it also
affects macos which I'm not sure that it wont break something. Would
one of our macos devs please take a look at this patch when you get a
chance.
Cheers,
Wayne
On 11/8/2018 6:51 PM, Brüns, Stefan wrote:
> Currently, the plugindir in the plugin manager is constructed as
> {CMAKE_INSTALL_PREFIX}/bin/../{CMAKE_INSTALL_LIBDIR}/kicad/..., while
> CMakes install uses {CMAKE_INSTALL_LIBDIR}/kicad/...
>
> In case CMAKE_INSTALL_LIBDIR is a relative path "install" prefixes it
> with CMAKE_INSTALL_PREFIX and both paths happen to match, otherwise
> the constructed path ends up as e.g. "/usr/bin/../usr/lib/kicad/...".
>
> For these cases where an absolute path is wanted CMake provides the
> CMAKE_INSTALL_FULL_<dir> variants which works the same as
> CMAKE_INSTALL_<dir> when used as DIRECTORY for install.
>
> Fixes https://bugs.launchpad.net/kicad/+bug/1796905
>
> Kind regards,
>
> Stefan
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : [email protected]
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
