Hi Seth, The Eeschema has one advantage that if you mess it up you get too many undo steps rather than too few. But it is somewhat crankier code to get right.
I agree that we should have only one scheme. I don’t believe anyone’s working on it — although it would probably be Tom if anyone was. Cheers, Jeff. > On 27 May 2019, at 15:30, Seth Hillbrand <s...@hillbrand.org> wrote: > > Hi Devs- > > We have two different paradigms for undo/redo stacks. The eeschema paradigm > and the pcbnew paradigm. In Eeschema, we add things directly to the undo > stack, optionally appending to the last item. In Pcbnew, we queue an undo > step in the frame until all items are added and then push the step to the > stack. > > Personally, I have found the pcbnew model to be much more robust and it > avoids passing around the "are we appending now?" flag to each intermediate > step. It also avoids having to change the undo stack when a command is > canceled. > > I'd like to move eeschema over to the pcbnew model. Is anyone working on > this already? > > -Seth > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
