That's interesting. I don't see it there yet.

Does your interface log the connections? I'll send another today and check for it again.

-Seth

On 2019-05-29 05:47, Maciej Suminski wrote:
If everything works as expected, then you should be able to see your
reports in my test project bug tracker [1]. The crash reporter should
receive link to the new bug report in the HTTP response, so I guess it
could be shown to the user.

Once we are confident with the crash reporter, I will modify the HTTP
request handler to create bug reports directly in the KiCad bug tracker.

Cheers,
Orson

1.
https://bugs.launchpad.net/kicad-git-test/+bugs?field.tag=crash-reporter&orderby=-id&start=0

On 5/29/19 6:07 AM, Seth Hillbrand wrote:
On 2019-05-28 12:13, Tomasz Wlostowski wrote:

Done (tom-crash-reporter-may27 on my Github)!

Tom

Hi Tom-

This looks very nice.  I like the implementation a lot!

Here are a couple minor bits:

1) The force crash dialog says "Clicking on OK will crash KiCad" but the
buttons say "Yes/No"
2) The crash report doesn't seem to pick up my build version
information.  It says:

KiCad crash report, version 1.0
--------------------------------------------------

application: kicad
version:     , release build

3) The tabbing changes in CMakeLists.txt are odd.  Intentional?
4) There's an untranslated string in OnSendReport ("Error sending cebug
report.")[sic]


No showstopper issues from my testing here.  I'd like to implement a
configurable destination address (maybe preferences or environmental
variable) but that can wait until after it's merged.

Thanks Tom (and Thomas) for an excellent addition!

Best-
Seth

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Reply via email to