JP, I took a look at your patch and I have a few comments.
Shouldn't the stack up dialog just be another panel the the board setup dialog? I would think this information is part of the board setup but I could be wrong. If the stack up information is part of the board setup then it should be in the "setup" section of the file format as well instead of a separate section. Change the "board_stackup" token to "stackup". Board is implied. I'm not sure "dielectric_constrains" is necessarily clear. Maybe "control_dielectric" would be more clear although I'm open to suggestion. The dialog layout definitely needs improved. The board thickness control has the units appended in the edit control along with the units displayed using static text. The layer color swatches are not aligned with the rest of the layer row controls. The color comboboxes are cutoff on GTK. The capitalization is incorrect for the check box and sizer strings. All in all, it's a good first step. I'm sure this will be improved over time to cover other board stack up parameters. Cheers, Wayne On 8/10/19 7:18 AM, jp charras wrote: > Since a long time, I started (slowly...) a layer stack manager. > The purpose is to allow users to define (for board fabrication) some > important parameters like: > - tech, copper and dielectric thickness > - color of some tech layers > - dielectric material > - board constraints. > > All of these parameters are in the .gbrjob file generated when plotting > gbr files. > Note also these parameters are not used in the board editor, only used > to fabricate the board. > > the dialog is available from the "Tools" menu. > > The ultimate purpose is to have something like a CAM tool to manage info > about the board fabrication and to create files needed to fabricate the > board all in once. > This is mandatory to ensure all files (gbr files, gbrjob files, > placement files and some others) are created at the same time, and use > the same settings. > The first step is this layer Stack Manager. > > Please test and comment. > Note also the dialog is not very good, but it is good enough (i hope) to > test the feature. > The main result of these settings is in the .gbrjob file. > Thanks. > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
