I see -DNDEBUG defined in windows release builds where CMake is configured with -DCMAKE_BUILD_TYPE=Release. Is this not the case with Linux and/or macos? Did we make the mistake of doing something like:
set( CMAKE_COMPILER_FLAGS "-foo" ) instead of: set( CMAKE_COMPILER_FLAGS "${CMAKE_COMPILER_FLAGS} -foo" ) in one of the none windows build code paths? Doing this will wipe out any compiler flags set by CMake. On 10/23/2019 11:16 AM, Ian McInerney wrote: > It looks like the build flags for KiCad are not getting NDEBUG defined > to remove the assertions. We should add -DNDEBUG to the flags passed > into CMake alongside the Debian flags. > > -Ian > > On Wed, Oct 23, 2019 at 6:38 AM Carsten Schoenert > <c.schoen...@t-online.de <mailto:c.schoen...@t-online.de>> wrote: > > Hello Seth, > > Am 22.10.19 um 18:10 schrieb Seth Hillbrand: > > Why do you have "hardening=+all" enabled? > > mostly because this is the default for building binary packages with > enabled hardening. > > https://wiki.debian.org/Hardening#Using_Hardening_Options > > > This is likely where the assertions are happening. We might consider > > "hardening=-all,+format,+fortify" > I'm not that deep into the details here or at least would need to keep > reading some stuff. But as far I've understand the hardening flags > should have no effect on this. > > Maybe Simon can give some enlightenment on this? > > -- > Regards > Carsten Schoenert > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp