I have not seen any packaging scripts depend on it, if it does I think it is fair for the package to be updated, but isn't it alreade handled by the make install step?
fre. 29. nov. 2019 12.59 skrev Ian McInerney <ian.s.mciner...@ieee.org>: > Thanks for the feedback. > > Steve, I won't be changing anything about how the version information is > generated, only adding a tag to the appdata file to contain the full > version (this will be the same as the version that gets displayed in the > help window, so it contains the distro-specific extra version as well). > > The main effect that this will have is that the kicad.appdata.xml file > will no longer be directly available in the source package, and will only > be available after CMake has been run. I wanted to make sure that this > wouldn't break any packaging scripts (which I think it wouldn't). > > Carsten, thanks for pointing those changes out. I will update the file > with them as well. Redoing the screenshots is also on my todo list (since > they still show a v4 release currently). Do you know what the guidelines > are for sizing of them? I see that the current ones are 1024x576, and I > can't seem to find any information on the suggested size (other than that > Fedora recommends they are 16:9). > > Thanks, > -Ian > > On Fri, Nov 29, 2019 at 5:39 AM Carsten Schoenert <c.schoen...@t-online.de> > wrote: > >> Hello Ian, >> >> On 28.11.19 17:53, Ian McInerney wrote: >> > I would like to change the way we generate the kicad.appdata.xml file to >> > have it be generated by CMake and include the version string inside of >> > it (that way the version will appear in the app stores and other places >> > that reference this). I don't think this will cause any issues, but I >> > just want to see if anyone sees any problems with this. >> >> this can't be a problem as the AppStream specification is holding a key >> for versioning information. Please see section 4.1.2, <releases> ... >> </releases> >> >> > >> https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#sect-Quickstart-DesktopApps >> >> If you touch this all I'd suggest to update all URLs within the appdata >> file as now the kicad-pcb.org domain is served by https. >> >> > $ git diff >> > diff --git a/resources/linux/appdata/kicad.appdata.xml >> b/resources/linux/appdata/kicad.appdata.xml >> > index 2fc29f0c1..550cb10c5 100644 >> > --- a/resources/linux/appdata/kicad.appdata.xml >> > +++ b/resources/linux/appdata/kicad.appdata.xml >> > @@ -46,27 +46,27 @@ >> > >> > <screenshots> >> > <screenshot type="default"> >> > - <image width="1024" height="576"> >> http://kicad-pcb.org/img/screenshots/appstream/kicad.png</image> >> > + <image width="1024" height="576"> >> https://kicad-pcb.org/img/screenshots/appstream/kicad.png</image> >> > </screenshot> >> > >> > <screenshot> >> > <caption>Eeschema Schematic Editor</caption> >> > - <image width="1024" height="576"> >> http://kicad-pcb.org/img/screenshots/appstream/eeschema.png</image> >> > + <image width="1024" height="576"> >> https://kicad-pcb.org/img/screenshots/appstream/eeschema.png</image> >> > </screenshot> >> > >> > <screenshot> >> > <caption>PcbNew PCB Layout</caption> >> > - <image width="1024" height="576"> >> http://kicad-pcb.org/img/screenshots/appstream/pcbnew.png</image> >> > + <image width="1024" height="576"> >> https://kicad-pcb.org/img/screenshots/appstream/pcbnew.png</image> >> > </screenshot> >> > >> > <screenshot> >> > <caption>PcbNew 3D Viewer</caption> >> > - <image width="1024" height="576"> >> http://kicad-pcb.org/img/screenshots/appstream/3dviewer.png</image> >> > + <image width="1024" height="576"> >> https://kicad-pcb.org/img/screenshots/appstream/3dviewer.png</image> >> > </screenshot> >> > </screenshots> >> > >> > - <url type="homepage">http://kicad-pcb.org/</url> >> > - <url type="bugtracker">http://kicad-pcb.org/help/report-a-bug/</url> >> > + <url type="homepage">https://kicad-pcb.org/</url> >> > + <url type="bugtracker">https://kicad-pcb.org/help/report-a-bug/ >> </url> >> > <update_contact>kicad-developers@lists.launchpad.net >> </update_contact> >> > <developer_name>The KiCad Developers</developer_name> >> > </component> >> >> This reminds me that all the screenshots should be updated too. ;) >> >> The validator for the AppData content within the Debian QA is mentioning >> that the component ID is not a reverse domain-name. Should get fixed too >> in case the file is getting changed. >> >> > https://appstream.debian.org/sid/main/issues/kicad.html >> >> -- >> Regards >> Carsten Schoenert >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp