It's been a while but if memory serves we stopped allowing KICAD_VERSION from being overridden because we were getting some odd package names. Only KICAD_VERSION_EXTRA user configurable.
On 12/17/19 3:39 PM, Nick Østergaard wrote: > As far as I understand it the non-extra version is not supposed to be > modified by the user/packager. So only adding custom stuff to the > _EXTRA is supposed to work "right". > > On Tue, 17 Dec 2019 at 21:29, Steven A. Falco <stevenfa...@gmail.com> wrote: >> >> On 12/17/19 3:13 PM, Ian McInerney wrote: >>> Is the version string supposed to be able to be overridden on the CMake >>> command line (e.g. specifying -DKICAD_VERSION="blah")? It appears that the >>> version string defined by CMake is always taking priority (then the git >>> string is used afterwards if it exists), so this flag is being overwritten. >>> >>> I assume that this is something we are fine with, (if so I can cleanup the >>> documentation and some of the CMake code around it). If not, then I guess >>> we need to fix it. >>> >>> Is there anyone actively trying to use the -DKICAD_VERSION flag? Should we >>> still support that (or only support the KICAD_VERSION_EXTRA flag? >> >> Fedora Linux only uses the KICAD_VERSION_EXTRA flag. >> >> Steve >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
