Ok, sounds good to me. lør. 28. dec. 2019 17.09 skrev Ian McInerney <ian.s.mciner...@ieee.org>:
> I have run a build on both OSX and Linux (with wxWidgets 3.0) and don't > see any more problems with the deprecation warnings (I fixed up the OSX > ones by turning off the OpenGL deprecation warnings, since Apple has > deprecated OpenGL, sigh...). I am going to go ahead and re-enable these > warnings in master. > > The main reason I am digging into this is to mark the DLIST class as > deprecated using the wxDEPRECATED_MSG macro (in response to > https://gitlab.com/kicad/code/kicad/issues/2623#note_258333603). > > -Ian > > On Sat, Dec 28, 2019 at 2:30 PM Ian McInerney <ian.s.mciner...@ieee.org> > wrote: > >> The commit that did it is this one from 2014: >> https://gitlab.com/kicad/code/kicad/commit/a3211b2b9e57a36c79f4ba2b00d0ac1aa30dceb3, >> but the log is literally just: "disable deprecation warnings in Debug >> build, change message in fp_lib_table.cpp," so I don't know what the actual >> reasoning behind the change was. >> >> -Ian >> >> On Sat, Dec 28, 2019 at 2:18 PM Nick Østergaard <oe.n...@gmail.com> >> wrote: >> >>> What does the git log tell you? >>> >>> I once did it in my build scripts because of: >>> >>> # Add flag to silence deprecation warnings >>> # Due to bug in gcc 5.1,5.2 >>> # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65974 >>> >>> So it would spew out a tremendous amount of unrelated warnings and was >>> useless. Maybe it was added because of that? Now, I don't think we >>> should use that globally. >>> >>> On Sat, 28 Dec 2019 at 15:09, Ian McInerney <ian.s.mciner...@ieee.org> >>> wrote: >>> > >>> > Is there a reason we disable warnings on deprecated declarations in >>> debug mode? Other than a lot of warnings about OpenGL being deprecated on >>> MacOS (gee, thanks Apple) that we can turn off pretty easily, I see no >>> reason we should be forcing this in our CMakeLists. I tried tracing this >>> back through the git history, but it is difficult to see why it was added. >>> > >>> > -Ian >>> > _______________________________________________ >>> > Mailing list: https://launchpad.net/~kicad-developers >>> > Post to : kicad-developers@lists.launchpad.net >>> > Unsubscribe : https://launchpad.net/~kicad-developers >>> > More help : https://help.launchpad.net/ListHelp >>> >>
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
