I agree, KICAD_PCM can be removed now. On Sat, Dec 25, 2021 at 7:27 AM Nick Østergaard <oe.n...@gmail.com> wrote:
> Having the unused parameters is no harm, it will only generate a > warning at configure time. > > The KICAD_PCM flag already defaults to ON, but I guess it should just > be removed as an option? Are there any reason to keep it as a toggle > for v6+? > > I am not aware of anything new flags for features in v7. > > On Fri, 24 Dec 2021 at 18:21, Steven A. Falco <stevenfa...@gmail.com> > wrote: > > > > I looked at CMakeLists.txt, and it appears that some of the old 5.x > build flags have been removed, and some new flags have been added. > > > > In particular, the following scripting flags are gone (only > KICAD_SCRIPTING_WXPYTHON remains): > > > > KICAD_SCRIPTING > > KICAD_SCRIPTING_ACTION_MENU > > KICAD_SCRIPTING_MODULES > > KICAD_SCRIPTING_PYTHON3 > > KICAD_SCRIPTING_WXPYTHON_PHOENIX > > > > These flags still appear in files like .gitlab/Windows-CI.yml and should > be removed. They should also be removed from the Fedora nightly builds, > and probably from other builds, as well. > > > > I can remove the above flags from the Fedora nightly builds, and I can > create an MR for the .gitlab files, if desired. Please let me know if you > want that MR. > > > > There are a few new flags that I think should be added to the Fedora > builds for clarity, even though we don't change the defaults. In > particular, I propose to add: > > > > KICAD_PCM=ON > > KICAD_USE_EGL=OFF > > > > Are there any other new flags that I should add? (I could add every > single flag from CMakeLists.txt, but most seem related to debug, and would > just clutter the cmake command.) > > > > Steve > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp