[
https://issues.apache.org/jira/browse/KITTY-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058083#comment-13058083
]
Alessandro Novarini commented on KITTY-16:
------------------------------------------
Hi Matthew,
Sorry, but I don't think the code breaks because of the application of the
patch, it's just the Gerben's patch that's missing :)
Question for Gerben: is there a reason why you created a ClientTest1 class
instead of adding tests to the actual ClientTest class? Just asking...
Anyway, the test Gerben wrote might work, but it's way too complicated to me,
this is a symptom that the SUT needs some refactoring, and 4 level of nested
ifs clearly tells everything :)
After we apply successfully the patch, I suggest to split the Client methods in
smaller ones and test them in a simpler way.
Obviously, I'm also offering to help!
> ls(): Invalid character ',' in key part of property
> ----------------------------------------------------
>
> Key: KITTY-16
> URL: https://issues.apache.org/jira/browse/KITTY-16
> Project: Kitty
> Issue Type: Bug
> Environment: Mac OS X
> IntelliJ 10
> Groovy 1.7.3
> Reporter: Matthew Sacks
> Priority: Blocker
> Labels: unbreaking
> Attachments: kitty-16.patch, kitty-16_1.patch, kitty-16_2.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> kitty> connect 127.0.0.1 9000
> connect 127.0.0.1 9000
> connecting to 127.0.0.1 at port 9000....
> the url is service:jmx:rmi:///jndi/rmi://127.0.0.1:9000/jmxrmi
> Successfully connected to host
> kitty> domains
> domains
> Domains Detected:
> 0: JMImplementation
> 1: Users
> 2: com.sun.management
> 3: Catalina
> 4: java.lang
> 5: java.util.logging
> kitty> setdomain Catalina
> setdomain Catalina
> Setting the domain to Catalina...
> The domain is set to Catalina
> kitty> ls
> ls
> listing files and directories...
> Invalid character ',' in key part of property
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
