http://bugs.async.com.br/show_bug.cgi?id=3781





--- Comment #3 from Johan Dahlin <[email protected]>  2009-03-24 17:48:25 
BRT ---
(From update of attachment 5162)
>Index: kiwi/dist.py

Thanks for the patch, looks good.

One comment, for a thing which could be reduced a bit though:

>+    try:
>+        kwargs['cmdclass'].update(cmdclass)
>+    except KeyError:
>+        kwargs['cmdclass'] = cmdclass

kwargs.setdefault('cmdclass', cmdclass).update(cmdclass)

Should be the same thing no?


-- 
Configure bugmail: http://bugs.async.com.br/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
_______________________________________________
Kiwi mailing list
[email protected]
http://www.async.com.br/mailman/listinfo/kiwi

Reply via email to