> On Jan. 3, 2013, 6:55 p.m., Łukasz Maszczyński wrote: > > Good, the tests are getting more and more readable with every update. > > Marko Käning wrote: > I see now that also testTwoInstitutions() and testOneInstitution() are > interfering, like my tests did before. > These two tests are inherently also used inside testAddAccounts(), which > complicates things further. > > I guess it looks like the tests would need a general overhaul independent > of what I am trying to implement here and I'd suggest to ship this patch for > now and open a new review for further changes to other tests, which will be > in any case a quite extensive project...
Ok, I understand. It sounds reasonable. - Łukasz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107619/#review24595 ----------------------------------------------------------- On Jan. 3, 2013, 7:45 p.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107619/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2013, 7:45 p.m.) > > > Review request for KMymoney and Łukasz Maszczyński. > > > Description > ------- > > The homepage accounts tables now show a different icon if there are > transactions for an account after the last online transaction - highlighting > for the user the necessity to download transactions in order to verify the > account status. > > > Diffs > ----- > > kmymoney/mymoney/mymoneyfile.h c43977ce7413eee2bc1e0a841fa548314c71e9df > kmymoney/mymoney/mymoneyfile.cpp 6640356d5e07152f8eb4aecff23d62ee8d853dbd > kmymoney/mymoney/mymoneyfiletest.h 5551fa94b6b34022c8e91c0301847d5479e6b1f2 > kmymoney/mymoney/mymoneyfiletest.cpp > feb9d57ecd7156fc1eea189a905fa797aeae9183 > kmymoney/views/khomeview.cpp c79337176b7265cabe15cad4972bc719e797af7c > > Diff: http://git.reviewboard.kde.org/r/107619/diff/ > > > Testing > ------- > > Built and ran application and test cases successfully. > > > Screenshots > ----------- > > example for the 4 possible cases of online status > http://git.reviewboard.kde.org/r/107619/s/948/ > > > Thanks, > > Marko Käning > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
