> On April 21, 2013, 3:39 p.m., Thomas Baumgart wrote: > > kmymoney/plugins/csvexport/csvwriter.cpp, line 218 > > <http://git.reviewboard.kde.org/r/109803/diff/3/?file=139981#file139981line218> > > > > Such constructs are the reason for so many performance problems (though > > not here I assume): why don't you simply write > > > > str += QLatin1String("R,"); > > > > Allan Anderson wrote: > I picked up on QStringBuilder recently and had the impression it improved > performance. I'm not saying what I've done is correct, and I bow to your > experience.
Just read http://blog.qt.digia.com/blog/2011/06/13/string-concatenation-with-qstringbuilder/ to get an idea of what QStringBuilder is and tries to achieve. Makes sense, but why would you want to concatenate to strings which are known at compile-time during run-time? That does not sound right to me. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/#review31365 ----------------------------------------------------------- On April 19, 2013, 7:52 p.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109803/ > ----------------------------------------------------------- > > (Updated April 19, 2013, 7:52 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > Add CSV export capability. Modify existing KMyMoney File menu in order to > make menu item positions more logical. > > > This addresses bug 317614. > http://bugs.kde.org/show_bug.cgi?id=317614 > > > Diffs > ----- > > kmymoney/plugins/CMakeLists.txt 81ca458 > kmymoney/plugins/csvexport/CMakeLists.txt PRE-CREATION > kmymoney/plugins/csvexport/csvexportdlg.h PRE-CREATION > kmymoney/plugins/csvexport/csvexportdlg.cpp PRE-CREATION > kmymoney/plugins/csvexport/csvexportdlgdecl.ui PRE-CREATION > kmymoney/plugins/csvexport/csvexporterplugin.h PRE-CREATION > kmymoney/plugins/csvexport/csvexporterplugin.cpp PRE-CREATION > kmymoney/plugins/csvexport/csvwriter.h PRE-CREATION > kmymoney/plugins/csvexport/csvwriter.cpp PRE-CREATION > kmymoney/plugins/csvexport/kmm_csvexport.desktop PRE-CREATION > kmymoney/plugins/csvexport/kmm_csvexport.rc PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109803/diff/ > > > Testing > ------- > > Exported numerous checking and investment CSV files, and then imported into > KMyMoney via CSV import (discovering a few minor issues in the existing > KMyMoney accounts in the process.) > Ran astyle and Krazy2. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel